You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mnemonic.apache.org by GitBox <gi...@apache.org> on 2021/08/20 05:30:21 UTC

[GitHub] [mnemonic] bigdata-memory commented on a change in pull request #239: MNEMONIC-673: Add pmalloc package into mnemonic source to reduce external dependencies

bigdata-memory commented on a change in pull request #239:
URL: https://github.com/apache/mnemonic/pull/239#discussion_r692668599



##########
File path: mnemonic-memory-services/mnemonic-pmalloc-service/src/main/native/CMakeLists.txt
##########
@@ -40,12 +40,29 @@ include_directories(${JNI_INCLUDE_DIRS})
 find_package(Threads REQUIRED)
 include_directories(${CMAKE_THREAD_LIBS_INIT})
 
-find_library(LIBPMALLOC_LIBRARIES NAMES libpmalloc_static.a)
-if (NOT LIBPMALLOC_LIBRARIES)
-   message(FATAL_ERROR "not found pmalloc library")
-endif (NOT LIBPMALLOC_LIBRARIES)
+#find_library(LIBPMALLOC_LIBRARIES NAMES libpmalloc_static.a)

Review comment:
       It can be removed if don't need it anymore, it is okay to keep it for reference as well, thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mnemonic.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org