You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by mice xia <mi...@tcloudcomputing.com> on 2012/08/07 07:41:57 UTC
Review Request: Fix unittest CheckPointManagerTest and
SecurityGroupManagerImpl2Test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6426/
-----------------------------------------------------------
Review request for cloudstack and Ewan Mellor.
Description
-------
changes:
-add more Dao/Managers in setup stage for SecurityGroupManagerImpl2Test
-add Mocks for SecurityGroupManagerImpl2Test
-add null check for pluggableServicesMap in ComponentLocator.java
Diffs
-----
server/test/com/cloud/network/security/SecurityGroupManagerImpl2Test.java c4887d8
server/test/com/cloud/projects/MockProjectManagerImpl.java PRE-CREATION
server/test/com/cloud/user/MockDomainManagerImpl.java PRE-CREATION
utils/src/com/cloud/utils/component/ComponentLocator.java 6669c0e
Diff: https://reviews.apache.org/r/6426/diff/
Testing
-------
verified
Thanks,
mice xia