You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/27 12:15:32 UTC

[GitHub] [spark] beliefer commented on a diff in pull request #39240: [SPARK-41440][CONNECT][PYTHON] Avoid the cache operator for general Sample.

beliefer commented on code in PR #39240:
URL: https://github.com/apache/spark/pull/39240#discussion_r1057644855


##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -381,7 +381,7 @@ message Sample {
 
   // (Optional) Explicitly sort the underlying plan to make the ordering deterministic.
   // This flag is only used to randomly splits DataFrame with the provided weights.
-  optional bool force_stable_sort = 6;
+  optional bool deterministic_order = 6;

Review Comment:
   OK



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org