You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/08/28 07:34:32 UTC

[GitHub] [calcite] libenchao commented on a diff in pull request #2885: [CALCITE-5249] RelToSqlConverter can't access the field of an struct array element

libenchao commented on code in PR #2885:
URL: https://github.com/apache/calcite/pull/2885#discussion_r956682804


##########
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##########
@@ -658,16 +659,18 @@ public SqlNode toSql(@Nullable RexProgram program, RexNode rex) {
           final SqlNode expr = toSql(program, referencedExpr);
           sqlIdentifier = new SqlIdentifier(expr.toString(), POS);
           break;
+        case ITEM:

Review Comment:
   The switch branch for `ROW` is not correct too. Maybe we should unify them and make this the default behavior?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org