You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/10/15 14:53:09 UTC
[kudu-CR](branch-1.11.x) util: gscoped ptr -> unique ptr
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14450
Change subject: util: gscoped_ptr<ThreadPool> -> unique_ptr<ThreadPool>
......................................................................
util: gscoped_ptr<ThreadPool> -> unique_ptr<ThreadPool>
This replaces all usages of gscoped_ptr<ThreadPool> with
unique_ptr<ThreadPool>.
I also made some trivial gscoped_ptr -> unique_ptr conversions here and
there, and replaced a couple `ifndef`s with `pragma once`s.
There are no functional changes in this patch.
Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983
Reviewed-on: http://gerrit.cloudera.org:8080/14419
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit bd7416aec2f865fe4c3d187801cc775b549cc84d)
---
M src/kudu/codegen/compilation_manager.h
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.h
M src/kudu/rpc/messenger.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/thrift/client.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_checksum.h
M src/kudu/tools/table_scanner.h
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/util/countdown_latch-test.cc
M src/kudu/util/curl_util-test.cc
M src/kudu/util/maintenance_manager.h
M src/kudu/util/net/dns_resolver.h
M src/kudu/util/threadpool-test.cc
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
M src/kudu/util/trace.h
29 files changed, 66 insertions(+), 89 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/14450/1
--
To view, visit http://gerrit.cloudera.org:8080/14450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983
Gerrit-Change-Number: 14450
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR](branch-1.11.x) util: gscoped ptr -> unique ptr
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14450 )
Change subject: util: gscoped_ptr<ThreadPool> -> unique_ptr<ThreadPool>
......................................................................
util: gscoped_ptr<ThreadPool> -> unique_ptr<ThreadPool>
This replaces all usages of gscoped_ptr<ThreadPool> with
unique_ptr<ThreadPool>.
I also made some trivial gscoped_ptr -> unique_ptr conversions here and
there, and replaced a couple `ifndef`s with `pragma once`s.
There are no functional changes in this patch.
Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983
Reviewed-on: http://gerrit.cloudera.org:8080/14419
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit bd7416aec2f865fe4c3d187801cc775b549cc84d)
Reviewed-on: http://gerrit.cloudera.org:8080/14450
---
M src/kudu/codegen/compilation_manager.h
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/kserver/kserver.h
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.h
M src/kudu/rpc/messenger.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/thrift/client.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_checksum.h
M src/kudu/tools/table_scanner.h
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/util/countdown_latch-test.cc
M src/kudu/util/curl_util-test.cc
M src/kudu/util/maintenance_manager.h
M src/kudu/util/net/dns_resolver.h
M src/kudu/util/threadpool-test.cc
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
M src/kudu/util/trace.h
29 files changed, 66 insertions(+), 89 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983
Gerrit-Change-Number: 14450
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) util: gscoped ptr -> unique ptr
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14450 )
Change subject: util: gscoped_ptr<ThreadPool> -> unique_ptr<ThreadPool>
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983
Gerrit-Change-Number: 14450
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Oct 2019 16:22:53 +0000
Gerrit-HasComments: No