You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Berenguer Blasi (Jira)" <ji...@apache.org> on 2020/06/03 07:38:00 UTC
[jira] [Comment Edited] (CASSANDRA-15845)
dtest-novnode.materialized_views_test.TestMaterializedViews.test_populate_mv_after_insert_wide_rows
[ https://issues.apache.org/jira/browse/CASSANDRA-15845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124701#comment-17124701 ]
Berenguer Blasi edited comment on CASSANDRA-15845 at 6/3/20, 7:37 AM:
----------------------------------------------------------------------
Hi [~jasonstack],
thx for the info. What I see is slightly different though. We do indeed [wait|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/view/ViewBuilderTask.java#L136] for schema agreement, but adding some logging on node1 we can see it _sees_ schema agreement while the other nodes2&3 don't know about the MV yet. Here is node1 under the wrong impression on schema agreement:
{noformat}
DEBUG [ViewBuildExecutor:1] 2020-06-02 17:31:46,137 Gossiper.java:2038 - Node: 127.0.0.3:7000 expectedVersion: null remoteVersion: a17bfd1c-15fd-30ad-9a5e-534b45062856
DEBUG [ViewBuildExecutor:1] 2020-06-02 17:31:46,137 Gossiper.java:2038 - Node: 127.0.0.2:7000 expectedVersion: a17bfd1c-15fd-30ad-9a5e-534b45062856 remoteVersion: a17bfd1c-15fd-30ad-9a5e-534b45062856
DEBUG [ViewBuildExecutor:1] 2020-06-02 17:31:46,137 Gossiper.java:2038 - Node: 127.0.0.1:7000 expectedVersion: a17bfd1c-15fd-30ad-9a5e-534b45062856 remoteVersion: a17bfd1c-15fd-30ad-9a5e-534b45062856
DEBUG [ViewBuildExecutor:1] 2020-06-02 17:31:46,137 Gossiper.java:2047 - Nodes agree on schema
{noformat}
I don't know if it's worth going down this race rabbit hole or if Is there a ticket around already I can mark this one a duplicate of? I can't seem to find one
Also do you think we should mark this test as a failure in dtests like it's suggested [here|https://issues.apache.org/jira/browse/CASSANDRA-14571?focusedCommentId=16549702&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16549702] until the underlying cause is fixed?
was (Author: bereng):
Hi [~jasonstack],
thx for the info. What I see is slightly different though. We do indeed [wait|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/view/ViewBuilderTask.java#L136] for schema agreement, but adding some logging on node1 we can see it _sees_ schema agreement while the other nodes2&3 don't know about the MV yet. Here is node1 under the wrong impression on schema agreement:
{noformat}
DEBUG [ViewBuildExecutor:1] 2020-06-02 17:31:46,137 Gossiper.java:2038 - Node: 127.0.0.3:7000 expectedVersion: null remoteVersion: a17bfd1c-15fd-30ad-9a5e-534b45062856
DEBUG [ViewBuildExecutor:1] 2020-06-02 17:31:46,137 Gossiper.java:2038 - Node: 127.0.0.2:7000 expectedVersion: a17bfd1c-15fd-30ad-9a5e-534b45062856 remoteVersion: a17bfd1c-15fd-30ad-9a5e-534b45062856
DEBUG [ViewBuildExecutor:1] 2020-06-02 17:31:46,137 Gossiper.java:2038 - Node: 127.0.0.1:7000 expectedVersion: a17bfd1c-15fd-30ad-9a5e-534b45062856 remoteVersion: a17bfd1c-15fd-30ad-9a5e-534b45062856
DEBUG [ViewBuildExecutor:1] 2020-06-02 17:31:46,137 Gossiper.java:2047 - Nodes agree on schema
{noformat}
I don't know if it's worth going down this race rabbit hole or if Is there a ticket around already I can mark this one a duplicate of? I can't seem to find one
> dtest-novnode.materialized_views_test.TestMaterializedViews.test_populate_mv_after_insert_wide_rows
> ---------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15845
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15845
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0-beta
>
>
> See failure [here|https://ci-cassandra.apache.org/job/Cassandra-trunk/155/testReport/dtest-novnode.materialized_views_test/TestMaterializedViews/test_populate_mv_after_insert_wide_rows_2/]
> {quote}Error Message
> assert 160 == 0 + where 160 = Row(count=160).count
> Stacktrace
> self = <materialized_views_test.TestMaterializedViews object at 0x7fcb232b5760>
> def test_populate_mv_after_insert_wide_rows(self):
> """Test that a view is OK when created with existing data with wide rows"""
> session = self.prepare(consistency_level=ConsistencyLevel.QUORUM)
>
> session.execute("CREATE TABLE t (id int, v int, PRIMARY KEY (id, v))")
>
> for i in range(5):
> for j in range(10000):
> session.execute("INSERT INTO t (id, v) VALUES ({}, {})".format(i, j))
>
> session.execute(("CREATE MATERIALIZED VIEW t_by_v AS SELECT * FROM t WHERE v IS NOT NULL "
> "AND id IS NOT NULL PRIMARY KEY (v, id)"))
>
> logger.debug("wait for view to build")
> self._wait_for_view("ks", "t_by_v")
>
> logger.debug("wait that all batchlogs are replayed")
> > self._replay_batchlogs()
> materialized_views_test.py:350:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> self = <materialized_views_test.TestMaterializedViews object at 0x7fcb232b5760>
> def _replay_batchlogs(self):
> for node in self.cluster.nodelist():
> if node.is_running():
> logger.debug("Replaying batchlog on node {}".format(node.name))
> node.nodetool("replaybatchlog")
> # CASSANDRA-13069 - Ensure replayed mutations are removed from the batchlog
> node_session = self.patient_exclusive_cql_connection(node)
> result = list(node_session.execute("SELECT count(*) FROM system.batches;"))
> > assert result[0].count == 0
> E assert 160 == 0
> E + where 160 = Row(count=160).count
> materialized_views_test.py:171: AssertionError{quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org