You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-dev@jackrabbit.apache.org by "rishabhdaim (via GitHub)" <gi...@apache.org> on 2026/03/23 05:29:29 UTC

[PR] OAK-12145 : add compatibility tests for Caffeine migration (PR 2807) [jackrabbit-oak]

rishabhdaim opened a new pull request, #2811:
URL: https://github.com/apache/jackrabbit-oak/pull/2811

   ## Summary
   
   Adds implementation-independent compatibility tests for every class touched by the Guava-to-Caffeine cache migration in [OAK-11946 / PR #2807](https://github.com/apache/jackrabbit-oak/pull/2807).
   
   All new tests reference **only Oak-level types** (`CacheLIRS`, `CacheStats`, `DiffCache`, etc.) — no direct imports of `org.apache.jackrabbit.guava.common.cache.*` or `com.github.benmanes.caffeine.cache.*`. The same test suite can be cherry-picked onto OAK-11946 and run unchanged; any failure there is a migration compatibility gap, not a test defect.
   
   ## Changes
   
   | Module | Files | What's covered |
   |--------|-------|----------------|
   | `oak-core-spi` | `AbstractCacheStatsTest`, `CacheLIRSCompatibilityTest`, `EmpiricalWeigherTest` | Stats counters/rates/reset, get/load/eviction callbacks, weigher overhead |
   | `oak-store-document` | `DocumentNodeStoreBuilderTest`, `NodeDocumentCacheTest`, `MemoryDiffCacheTest`, `TieredDiffCacheTest`, `LocalDiffCacheCompatibilityTest`, `PersistentCacheCompatibilityTest`, `CommitValueResolverTest`, `DocumentNodeStoreTest` | Builder cache selection, cache CRUD, ExecutionException contract, invalidation, persistent cache durability |
   | `oak-run-commons` | `DocumentNodeStoreHelperTest` | `getNodesCache` return type and `asMap` contract |
   | `oak-search` | `ExtractedTextCacheTest` | Stats request/miss counts |
   | `oak-search-elastic` | `ElasticIndexStatisticsCompatibilityTest` | Cache hit, background refresh, stale-value-during-refresh, failure retention |
   | `oak-segment-tar` | `SegmentCacheTest` | Loader failure wrapped in `ExecutionException` |
   | `oak-blob` | `BlobIdSetCompatibilityTest` | Cache miss / file-persistence semantics |
   | `oak-blob-cloud` | `S3BackendTest` | Expiry setters, cache enable/disable, URI cache hit |
   | `oak-blob-cloud-azure` | `AzureBlobStoreBackendCompatibilityTest`, `AzureBlobStoreBackendV8Test` | Expiry setters, cache enable/disable |
   
   ## Test Plan
   
   - [x] All new tests pass on this branch (Guava baseline)
   - [ ] Cherry-pick to OAK-11946 and verify same tests pass (next step)
   - [ ] Any failure on OAK-11946 is treated as a compatibility gap to fix there
   
   ## Links
   
   - JIRA: https://issues.apache.org/jira/browse/OAK-12145
   - Migration PR under test: https://github.com/apache/jackrabbit-oak/pull/2807


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-12145 : add compatibility tests for Caffeine migration (PR 2807) [jackrabbit-oak]

Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.

rishabhdaim merged PR #2811:
URL: https://github.com/apache/jackrabbit-oak/pull/2811


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-12145 : add compatibility tests for Caffeine migration (PR 2807) [jackrabbit-oak]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.

sonarqubecloud[bot] commented on PR #2811:
URL: https://github.com/apache/jackrabbit-oak/pull/2811#issuecomment-4109295392

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2811) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [16 New issues](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2811&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2811&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2811&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2811&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2811&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2811)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org