You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/03 19:53:09 UTC
[GitHub] reminisce commented on issue #12502: [NGRAPH] MXNet - nGraph
initial integration
reminisce commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration
URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-426777086
@mbrookhart Thanks for the contribution. I'm still concerned that the dedicated unit tests are missing for a feature like this. I understand you have enabled testing this feature with the existing test set. However, we don't know whether the test coverage is sufficient. Can you add dedicated unit tests similar to what did in `test_subgraph_op.py` for default subgraph property?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services