You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@isis.apache.org by Boris Toninski <bo...@orangedot.bg> on 2016/05/18 10:29:47 UTC
todoapp build failing
Hi,
I found that there is a ticket about this - https://github.com/isisaddons/isis-app-todoapp/issues/9, but it seems nobody looked at it.
Thanks,
Boris
Re: todoapp build failing
Posted by Óscar Bou - GOVERTIS <o....@govertis.com>.
Hi Stephen.
Create your own account on Github.
Clone the Apache-Isis repository to
Your account.
Download it locally by using any git client (or make "simple" edits online using the Github editor).
If changed locally, push changes to your own. GitHub repo on a new brand (I.e., ISIS-xxxx, being the number of the Jira ticket; or a simple name detailing it - but preferred method is with a ticket associated).
Then on Github you will have the option to create a Pull Request of the latest changes made in a branch in your local repo, to the Apache Isis main repo.
HTH,
Oscar
> El 19 may 2016, a las 0:43, Stephen Cameron <st...@gmail.com> escribió:
>
> learning hot to do PRs are on my todo list, nearing top
>
> On Wed, May 18, 2016 at 9:33 PM, Dan Haywood <da...@haywood-associates.co.uk>
> wrote:
>
>> Probably, yes. Updating the todo app is, um, on my todo list!
>>
>> PRs happily received...
>> On 18 May 2016 12:30 pm, "Stephen Cameron" <st...@gmail.com>
>> wrote:
>>
>> Current release version is 1.12.1, so changing to that in the parent
>> pom.xml should fix the problem, an oversight I guess
>>
>> <properties>
>> <isis.version>1.12.1</isis.version>
>> </properties>
>>
>> On Wed, May 18, 2016 at 8:29 PM, Boris Toninski <
>> boris.toninski@orangedot.bg
>>> wrote:
>>
>>> Hi,
>>>
>>> I found that there is a ticket about this -
>>> https://github.com/isisaddons/isis-app-todoapp/issues/9, but it seems
>>> nobody looked at it.
>>>
>>> Thanks,
>>> Boris
>>
Re: todoapp build failing
Posted by Stephen Cameron <st...@gmail.com>.
learning hot to do PRs are on my todo list, nearing top
On Wed, May 18, 2016 at 9:33 PM, Dan Haywood <da...@haywood-associates.co.uk>
wrote:
> Probably, yes. Updating the todo app is, um, on my todo list!
>
> PRs happily received...
> On 18 May 2016 12:30 pm, "Stephen Cameron" <st...@gmail.com>
> wrote:
>
> Current release version is 1.12.1, so changing to that in the parent
> pom.xml should fix the problem, an oversight I guess
>
> <properties>
> <isis.version>1.12.1</isis.version>
> </properties>
>
> On Wed, May 18, 2016 at 8:29 PM, Boris Toninski <
> boris.toninski@orangedot.bg
> > wrote:
>
> > Hi,
> >
> > I found that there is a ticket about this -
> > https://github.com/isisaddons/isis-app-todoapp/issues/9, but it seems
> > nobody looked at it.
> >
> > Thanks,
> > Boris
> >
> >
>
Re: todoapp build failing
Posted by Dan Haywood <da...@haywood-associates.co.uk>.
Probably, yes. Updating the todo app is, um, on my todo list!
PRs happily received...
On 18 May 2016 12:30 pm, "Stephen Cameron" <st...@gmail.com>
wrote:
Current release version is 1.12.1, so changing to that in the parent
pom.xml should fix the problem, an oversight I guess
<properties>
<isis.version>1.12.1</isis.version>
</properties>
On Wed, May 18, 2016 at 8:29 PM, Boris Toninski <boris.toninski@orangedot.bg
> wrote:
> Hi,
>
> I found that there is a ticket about this -
> https://github.com/isisaddons/isis-app-todoapp/issues/9, but it seems
> nobody looked at it.
>
> Thanks,
> Boris
>
>
Re: todoapp build failing
Posted by Stephen Cameron <st...@gmail.com>.
Current release version is 1.12.1, so changing to that in the parent
pom.xml should fix the problem, an oversight I guess
<properties>
<isis.version>1.12.1</isis.version>
</properties>
On Wed, May 18, 2016 at 8:29 PM, Boris Toninski <boris.toninski@orangedot.bg
> wrote:
> Hi,
>
> I found that there is a ticket about this -
> https://github.com/isisaddons/isis-app-todoapp/issues/9, but it seems
> nobody looked at it.
>
> Thanks,
> Boris
>
>