[jira] [Commented] (CURATOR-27) PathChildrenCache creates but doesn't shut down Executors

["Jordan Zimmerman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CURATOR-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744556#comment-13744556 ] 

Jordan Zimmerman commented on CURATOR-27:
-----------------------------------------

Comments on the patch:

* I usually use executorService.shutdownNow() instead of executorService.shutdown(). If shutdown is being called it usually means executing tasks shouldn't complete but instead be interrupted. Thoughts?

* nitpick: referencing instance fields via "this." is unnecessary and confusing.

* PathChildrenCache line 144 - why isn't "true" passed for shutdown in CloseableExecutorService?

* Looks like the pom change to exclude IDEA files got merged into this patch. It shouldn't be.


                
> PathChildrenCache creates but doesn't shut down Executors
> ---------------------------------------------------------
>
>                 Key: CURATOR-27
>                 URL: https://issues.apache.org/jira/browse/CURATOR-27
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.0.1-incubating
>            Reporter: Ioannis Canellos
>            Assignee: Ioannis Canellos
>         Attachments: CURATOR-27.patch
>
>
> After the introduction of the CloseableExecutorService (see CURATOR-17) the PathChildrenCache may create Executor services that it doesn't close.
> Ideally, the CloseableExecutorService should accept a parameter that specifies if the executor needs to be shutdown on close. Recipes that create their own ExecutorService should set this parameter to true. When an executor not directly managed by the recipe is used, the flag should be just false, so that the the executor doesn't always close (satisfy CURATOR-17).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira