[GitHub] betodealmeida commented on a change in pull request #4400: Allowing config flag to turn off javascript controls

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #4400: Allowing config flag to turn off javascript controls
URL: https://github.com/apache/incubator-superset/pull/4400#discussion_r169482309
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -948,7 +956,12 @@ def get_form_data(self):
 
         if request.args.get('viz_type'):
             # Converting old URLs
-            d = cast_form_data(request.args)
+            d = cast_form_data(d)
+
+        for k in FORM_DATA_KEY_BLACKLIST:
 
 Review comment:
   Nit: you can do this in a single line
   
   ```python
   d = {k: v for k, v in d.items() if k not in FORM_DATA_KEY_BLACKLIST}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services