You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/25 11:04:13 UTC

[GitHub] [incubator-dolphinscheduler] qiaozhanwei opened a new pull request #1575: remove kazoo

qiaozhanwei opened a new pull request #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575
 
 
   1，install.sh remove kazoo
   2，MonitorServer and script 
   3，RemoveZKNode and script

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1575: remove kazoo

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575#issuecomment-568888463
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=h1) Report
   > Merging [#1575](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/026fdd9e1c2fab944776c6cc09716d0b5b185baa?src=pr&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             dev   #1575      +/-   ##
   ========================================
   - Coverage   7.58%   7.55%   -0.04%     
   ========================================
     Files        277     281       +4     
     Lines      13743   13812      +69     
     Branches    2194    2205      +11     
   ========================================
     Hits        1043    1043              
   - Misses     12631   12700      +69     
     Partials      69      69
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...dolphinscheduler/server/monitor/MonitorServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvTW9uaXRvclNlcnZlci5qYXZh) | `0% <0%> (ø)` | |
   | [...lphinscheduler/server/monitor/AbstractMonitor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvQWJzdHJhY3RNb25pdG9yLmphdmE=) | `0% <0%> (ø)` | |
   | [...er/common/utils/placeholder/BusinessTimeUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3BsYWNlaG9sZGVyL0J1c2luZXNzVGltZVV0aWxzLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...olphinscheduler/server/monitor/ZKMmonitorImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvWktNbW9uaXRvckltcGwuamF2YQ==) | `0% <0%> (ø)` | |
   | [...he/dolphinscheduler/server/utils/RemoveZKNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1JlbW92ZVpLTm9kZS5qYXZh) | `0% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=footer). Last update [026fdd9...6575686](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1575: remove kazoo

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575#issuecomment-568888463
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`dev@e092a46`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `9.8%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=tree)
   
   ```diff
   @@          Coverage Diff          @@
   ##             dev   #1575   +/-   ##
   =====================================
     Coverage       ?   7.55%           
   =====================================
     Files          ?     281           
     Lines          ?   13812           
     Branches       ?    2205           
   =====================================
     Hits           ?    1043           
     Misses         ?   12700           
     Partials       ?      69
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | |
   | [...dolphinscheduler/server/monitor/MonitorServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvTW9uaXRvclNlcnZlci5qYXZh) | `0% <0%> (ø)` | |
   | [...he/dolphinscheduler/server/utils/RemoveZKNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1JlbW92ZVpLTm9kZS5qYXZh) | `0% <0%> (ø)` | |
   | [...er/common/utils/placeholder/BusinessTimeUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3BsYWNlaG9sZGVyL0J1c2luZXNzVGltZVV0aWxzLmphdmE=) | `0% <0%> (ø)` | |
   | [...lphinscheduler/server/monitor/AbstractMonitor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvQWJzdHJhY3RNb25pdG9yLmphdmE=) | `0% <0%> (ø)` | |
   | [...olphinscheduler/server/monitor/ZKMmonitorImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvWktNbW9uaXRvckltcGwuamF2YQ==) | `0% <0%> (ø)` | |
   | [...dolphinscheduler/common/queue/TaskQueueZkImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3F1ZXVlL1Rhc2tRdWV1ZVprSW1wbC5qYXZh) | `71.66% <100%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=footer). Last update [e092a46...6575686](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] dailidong closed pull request #1575: remove kazoo

Posted by GitBox <gi...@apache.org>.

dailidong closed pull request #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on a change in pull request #1575: remove kazoo

Posted by GitBox <gi...@apache.org>.

qiaozhanwei commented on a change in pull request #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575#discussion_r361306199
 
 

 ##########
 File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
 ##########
 @@ -36,6 +36,12 @@
      */
     public static final String HADOOP_PROPERTIES_PATH = "/common/hadoop/hadoop.properties";
 
+
+    /**
+     * run config
+     */
+    public static final String RUN_CONFIG = "/config/run_config.conf";
 
 Review comment:
   this not use，I will remove

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on a change in pull request #1575: remove kazoo

Posted by GitBox <gi...@apache.org>.

qiaozhanwei commented on a change in pull request #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575#discussion_r361306153
 
 

 ##########
 File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/monitor/RunConfig.java
 ##########
 @@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.server.monitor;
+
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.context.annotation.PropertySource;
+import org.springframework.stereotype.Component;
+
+/**
+ * zookeeper conf
+ */
+@Component
+@PropertySource("classpath:config/run_config.conf")
+public class RunConfig {
 
 Review comment:
   install.sh write conf file， not monitor config , monitor server only read

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on a change in pull request #1575: remove kazoo

Posted by GitBox <gi...@apache.org>.

qiaozhanwei commented on a change in pull request #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575#discussion_r361306006
 
 

 ##########
 File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/monitor/ZKMmonitorImpl.java
 ##########
 @@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.server.monitor;
+
+import org.apache.dolphinscheduler.common.zk.ZookeeperOperator;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Component;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * zk monitor server impl
+ */
+@Component
+public class ZKMmonitorImpl extends AbstractMonitor {
 
 Review comment:
   OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1575: remove kazoo

Posted by GitBox <gi...@apache.org>.

Technoboy- commented on a change in pull request #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575#discussion_r361303483
 
 

 ##########
 File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/monitor/ZKMmonitorImpl.java
 ##########
 @@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.server.monitor;
+
+import org.apache.dolphinscheduler.common.zk.ZookeeperOperator;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Component;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * zk monitor server impl
+ */
+@Component
+public class ZKMmonitorImpl extends AbstractMonitor {
 
 Review comment:
   ZKMonitorImpl

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1575: remove kazoo

Posted by GitBox <gi...@apache.org>.

Technoboy- commented on a change in pull request #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575#discussion_r361303810
 
 

 ##########
 File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
 ##########
 @@ -36,6 +36,12 @@
      */
     public static final String HADOOP_PROPERTIES_PATH = "/common/hadoop/hadoop.properties";
 
+
+    /**
+     * run config
+     */
+    public static final String RUN_CONFIG = "/config/run_config.conf";
 
 Review comment:
   How about naming monitor_config.conf

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] dailidong commented on a change in pull request #1575: remove kazoo

Posted by GitBox <gi...@apache.org>.

dailidong commented on a change in pull request #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575#discussion_r361304202
 
 

 ##########
 File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/monitor/ZKMmonitorImpl.java
 ##########
 @@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.server.monitor;
+
+import org.apache.dolphinscheduler.common.zk.ZookeeperOperator;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Component;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * zk monitor server impl
+ */
+@Component
+public class ZKMmonitorImpl extends AbstractMonitor {
 
 Review comment:
   > ZKMonitorImpl
   
   +1
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1575: remove kazoo

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575#issuecomment-568888463
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=h1) Report
   > Merging [#1575](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/026fdd9e1c2fab944776c6cc09716d0b5b185baa?src=pr&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             dev   #1575      +/-   ##
   ========================================
   - Coverage   7.58%   7.55%   -0.04%     
   ========================================
     Files        277     281       +4     
     Lines      13743   13811      +68     
     Branches    2194    2204      +10     
   ========================================
     Hits        1043    1043              
   - Misses     12631   12699      +68     
     Partials      69      69
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...dolphinscheduler/server/monitor/MonitorServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvTW9uaXRvclNlcnZlci5qYXZh) | `0% <0%> (ø)` | |
   | [...lphinscheduler/server/monitor/AbstractMonitor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvQWJzdHJhY3RNb25pdG9yLmphdmE=) | `0% <0%> (ø)` | |
   | [...dolphinscheduler/server/monitor/ZKMonitorImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvWktNb25pdG9ySW1wbC5qYXZh) | `0% <0%> (ø)` | |
   | [...he/dolphinscheduler/server/utils/RemoveZKNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1JlbW92ZVpLTm9kZS5qYXZh) | `0% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=footer). Last update [026fdd9...f096f5d](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1575: remove kazoo

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575#issuecomment-568888463
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=h1) Report
   > Merging [#1575](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/026fdd9e1c2fab944776c6cc09716d0b5b185baa?src=pr&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             dev   #1575      +/-   ##
   ========================================
   - Coverage   7.58%   7.55%   -0.04%     
   ========================================
     Files        277     281       +4     
     Lines      13743   13812      +69     
     Branches    2194    2205      +11     
   ========================================
     Hits        1043    1043              
   - Misses     12631   12700      +69     
     Partials      69      69
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...dolphinscheduler/server/monitor/MonitorServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvTW9uaXRvclNlcnZlci5qYXZh) | `0% <0%> (ø)` | |
   | [...lphinscheduler/server/monitor/AbstractMonitor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvQWJzdHJhY3RNb25pdG9yLmphdmE=) | `0% <0%> (ø)` | |
   | [...er/common/utils/placeholder/BusinessTimeUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3BsYWNlaG9sZGVyL0J1c2luZXNzVGltZVV0aWxzLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...olphinscheduler/server/monitor/ZKMmonitorImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvWktNbW9uaXRvckltcGwuamF2YQ==) | `0% <0%> (ø)` | |
   | [...he/dolphinscheduler/server/utils/RemoveZKNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1JlbW92ZVpLTm9kZS5qYXZh) | `0% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=footer). Last update [026fdd9...6575686](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1575?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1575: remove kazoo

Posted by GitBox <gi...@apache.org>.

Technoboy- commented on a change in pull request #1575: remove kazoo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1575#discussion_r361303736
 
 

 ##########
 File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/monitor/RunConfig.java
 ##########
 @@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.server.monitor;
+
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.context.annotation.PropertySource;
+import org.springframework.stereotype.Component;
+
+/**
+ * zookeeper conf
+ */
+@Component
+@PropertySource("classpath:config/run_config.conf")
+public class RunConfig {
 
 Review comment:
   How about naming MonitorConfig

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services