You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "henry3260 (via GitHub)" <gi...@apache.org> on 2025/11/04 12:39:14 UTC
[PR] fix MyPy type errors in deadline.py [airflow]
henry3260 opened a new pull request, #57799:
URL: https://github.com/apache/airflow/pull/57799
Sub task of https://github.com/apache/airflow/issues/56735.
This is a common static error when SQLA2 is used.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix MyPy type errors in deadline.py [airflow]
Posted by "henry3260 (via GitHub)" <gi...@apache.org>.
henry3260 commented on code in PR #57799:
URL: https://github.com/apache/airflow/pull/57799#discussion_r2491016856
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -414,6 +414,7 @@ def _evaluate_with(self, *, session: Session, **kwargs: Any) -> datetime | None:
dialect = get_dialect_name(session)
# Create database-specific expression for calculating duration in seconds
+ duration_expr: Any | None = None
Review Comment:
> Does not `Any` include `None`? And I think we can guess the type of `duration_expr` It is used below to build the query so I guess the type should be pretty straightforward to guess
Can I use `duration_expr: ColumnElement[Any]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix MyPy type errors in deadline.py [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #57799:
URL: https://github.com/apache/airflow/pull/57799#discussion_r2491114218
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -414,6 +414,7 @@ def _evaluate_with(self, *, session: Session, **kwargs: Any) -> datetime | None:
dialect = get_dialect_name(session)
# Create database-specific expression for calculating duration in seconds
+ duration_expr: Any | None = None
Review Comment:
I like it better. Maybe @uranusjr has a better idea though (sorry to ping you TP but your comments on these mypy PRs are very valuable :))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix MyPy type errors in deadline.py [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #57799:
URL: https://github.com/apache/airflow/pull/57799#issuecomment-3485791254
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix MyPy type errors in deadline.py [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #57799:
URL: https://github.com/apache/airflow/pull/57799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix MyPy type errors in deadline.py [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #57799:
URL: https://github.com/apache/airflow/pull/57799#discussion_r2490870191
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -107,7 +107,7 @@ class Deadline(Base):
# The time after which the Deadline has passed and the callback should be triggered.
deadline_time: Mapped[datetime] = mapped_column(UtcDateTime, nullable=False)
# The (serialized) callback to be called when the Deadline has passed.
- _callback: Mapped[dict] = mapped_column(
+ _callback: Mapped[Any] = mapped_column(
Review Comment:
We should not do that, given the type `JSONField`, it should be `dict`
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -414,6 +414,7 @@ def _evaluate_with(self, *, session: Session, **kwargs: Any) -> datetime | None:
dialect = get_dialect_name(session)
# Create database-specific expression for calculating duration in seconds
+ duration_expr: Any | None = None
Review Comment:
Does not `Any` include `None`? And I think we can guess the type of `duration_expr` It is used below to build the query so I guess the type should be pretty straightforward to guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org