You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jeremy Daggett <no...@github.com> on 2014/10/09 00:55:01 UTC
[jclouds-labs-openstack] Support OpenStack Heat StackApi list()
method (#159)
This PR adds support for the `StackApi` and listing stacks. This is a WIP.
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-labs-openstack openstack/heat
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/159
-- Commit Summary --
* JCLOUDS-694: Support StackApi list()
-- File Changes --
M openstack-heat/src/main/java/org/jclouds/openstack/heat/v1/HeatApi.java (7)
A openstack-heat/src/main/java/org/jclouds/openstack/heat/v1/domain/Stack.java (490)
M openstack-heat/src/main/java/org/jclouds/openstack/heat/v1/features/ResourceApi.java (4)
A openstack-heat/src/main/java/org/jclouds/openstack/heat/v1/features/StackApi.java (55)
A openstack-heat/src/test/java/org/jclouds/openstack/heat/v1/features/StackApiLiveTest.java (43)
A openstack-heat/src/test/java/org/jclouds/openstack/heat/v1/features/StackApiMockTest.java (93)
M openstack-heat/src/test/java/org/jclouds/openstack/heat/v1/internal/BaseHeatApiLiveTest.java (24)
A openstack-heat/src/test/resources/stack_list_response.json (19)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-openstack/pull/159.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/159.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/159
Re: [jclouds-labs-openstack] Support OpenStack Heat StackApi list()
method (#159)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #455](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/455/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/159#issuecomment-58442621
Re: [jclouds-labs-openstack] Support OpenStack Heat StackApi list()
method (#159)
Posted by inbar stolberg <no...@github.com>.
hey @jdaggett I see it has been a while since you touched this PR.
I am interested in this code, any idea when will it merge.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/159#issuecomment-65060082
Re: [jclouds-labs-openstack] Support OpenStack Heat StackApi list()
method (#159)
Posted by Everett Toews <no...@github.com>.
> return props;
> }
>
> + @Override
> + @BeforeClass(groups = "live")
> + public void setup() {
> + super.setup();
> + String providedRegion = System.getProperty("test." + LocationConstants.PROPERTY_REGION);
> + if (providedRegion != null) {
> + regions = ImmutableSet.of(providedRegion);
> + } else {
> + regions = api.getConfiguredRegions();
> + }
> +
> + // create a stack
Hanging comment?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/159/files#r21987566
Re: [jclouds-labs-openstack] Support OpenStack Heat StackApi list()
method (#159)
Posted by Everett Toews <no...@github.com>.
Thanks for the pull request but it's release week in jclouds and that means it's time to clean up the PR queue. This PR will be over 6 months old as of April 1. If you intend to continue work on it, please make a comment by April 2. Otherwise it will be closed on April 3.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/159#issuecomment-85718052
Re: [jclouds-labs-openstack] Support OpenStack Heat StackApi list()
method (#159)
Posted by Everett Toews <no...@github.com>.
> + /**
> + * @param capabilities The capabilities of this Stack.
> + * @return The builder object.
> + * @see Stack#getCapabilities()
> + */
> + public T capabilities(Set<String> capabilities) {
> + this.capabilities = capabilities;
> + return self();
> + }
> +
> + /**
> + * @param parameters The parameters of this Stack.
> + * @return The builder object.
> + * @see Stack#getParameters()
> + */
> +// public Builder parameters(Set<StackParameter> parameters) {
Should this commented out code be deleted?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/159/files#r21987223
Re: [jclouds-labs-openstack] Support OpenStack Heat StackApi list()
method (#159)
Posted by Everett Toews <no...@github.com>.
> +
> + try {
> + HeatApi heatApi = api(server.getUrl("/").toString(), "openstack-heat", overrides);
> + StackApi api = heatApi.getStackApi("RegionOne");
> +
> + AutoStack stack = api.get("simple_stack", "3095aefc-09fb-4bc7-b1f0-f21a304e864c");
> + System.out.println(stack);
> +
> + Method[] methods = stack.getClass().getDeclaredMethods();
> + for (Method m : methods) {
> + System.out.println(m.getName());
> + }
> +
> + /*
> + * Check request
> + */
The asserts in any of these tests don't require comments.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/159/files#r21987503
Re: [jclouds-labs-openstack] Support OpenStack Heat StackApi list()
method (#159)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1855](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1855/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/159#issuecomment-59546036
Re: [jclouds-labs-openstack] Support OpenStack Heat StackApi list()
method (#159)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1825](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1825/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/159#issuecomment-58442402
Re: [jclouds-labs-openstack] Support OpenStack Heat StackApi list()
method (#159)
Posted by Everett Toews <no...@github.com>.
> + for (Method m : methods) {
> + System.out.println(m.getName());
> + }
> +
> + /*
> + * Check request
> + */
> + assertThat(server.getRequestCount()).isEqualTo(2);
> + assertAuthentication(server);
> + assertRequest(server.takeRequest(), "GET", BASE_URI + "/stacks/simple_stack/3095aefc-09fb-4bc7-b1f0-f21a304e864c");
> +
> + /*
> + * Check response
> + */
> + assertThat(stack).isNotNull();
> + //assertThat(stacks.size()).isEqualTo(1);
Commented? Remove it?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/159/files#r21987518
Re: [jclouds-labs-openstack] Support OpenStack Heat StackApi list()
method (#159)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #466](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/466/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/159#issuecomment-59545740