You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "sjyango (via GitHub)" <gi...@apache.org> on 2024/02/01 16:27:29 UTC
[PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
sjyango opened a new pull request, #30730:
URL: https://github.com/apache/doris/pull/30730
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
change IPv6 to little-endian byte order storage (like IPv4), in order to ensure unified storage and computation.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1923523323
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 668c08ea82f99cbd0da249ead022113095be3e1a with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.3 seconds inserted 10000000 Rows, about 751K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1923486920
<details>
<summary>TPC-H: <b>Total hot run time: 37202 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 668c08ea82f99cbd0da249ead022113095be3e1a, data reload: false
------ Round 1 ----------------------------------
q1 17623 5109 4546 4546
q2 2041 142 132 132
q3 10598 904 910 904
q4 4639 797 767 767
q5 7694 2902 2912 2902
q6 183 120 117 117
q7 1132 734 726 726
q8 9287 2003 2024 2003
q9 7252 6410 6353 6353
q10 8061 2447 2419 2419
q11 420 201 209 201
q12 746 280 291 280
q13 18012 3315 3313 3313
q14 274 250 252 250
q15 546 489 492 489
q16 469 418 413 413
q17 938 532 507 507
q18 6844 6018 5921 5921
q19 1569 1459 1348 1348
q20 619 325 338 325
q21 7021 2988 3077 2988
q22 809 298 310 298
Total cold run time: 106777 ms
Total hot run time: 37202 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4452 4458 4406 4406
q2 330 232 239 232
q3 3001 2836 2807 2807
q4 1848 1622 1620 1620
q5 5228 5240 5221 5221
q6 190 112 116 112
q7 2127 1798 1814 1798
q8 3119 3217 3252 3217
q9 8392 8329 8373 8329
q10 5842 3527 3512 3512
q11 540 456 475 456
q12 722 581 571 571
q13 14440 3075 3045 3045
q14 295 246 268 246
q15 539 496 480 480
q16 492 470 487 470
q17 1814 1702 1705 1702
q18 7917 7806 7639 7639
q19 8878 1518 1526 1518
q20 2159 1903 1923 1903
q21 4859 4661 4621 4621
q22 582 470 428 428
Total cold run time: 77766 ms
Total hot run time: 54333 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1925755728
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1921715065
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "sjyango (via GitHub)" <gi...@apache.org>.
sjyango commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1925594885
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1921899613
<details>
<summary>TPC-DS: <b>Total hot run time: 174451 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5ed1be9d1179c3347f41b3a8996bef9c031c00dd, data reload: false
query1 926 334 330 330
query2 6563 1841 1925 1841
query3 6696 207 198 198
query4 31938 22044 22102 22044
query5 4450 363 416 363
query6 254 163 152 152
query7 4607 266 265 265
query8 232 165 171 165
query9 9231 2262 2257 2257
query10 405 202 213 202
query11 18430 15506 15239 15239
query12 122 72 62 62
query13 1622 384 376 376
query14 9814 7355 7246 7246
query15 209 180 177 177
query16 7314 264 251 251
query17 1853 504 462 462
query18 1926 252 250 250
query19 186 135 129 129
query20 73 66 75 66
query21 203 124 127 124
query22 5088 4863 4879 4863
query23 31108 30301 30278 30278
query24 7079 2798 2738 2738
query25 531 305 301 301
query26 727 135 138 135
query27 2322 278 294 278
query28 4953 1851 1830 1830
query29 921 618 615 615
query30 278 131 133 131
query31 926 711 702 702
query32 91 55 53 53
query33 442 213 205 205
query34 809 455 458 455
query35 849 777 767 767
query36 1005 939 895 895
query37 95 58 64 58
query38 3242 3176 3158 3158
query39 1294 1254 1249 1249
query40 191 92 86 86
query41 40 34 33 33
query42 88 84 81 81
query43 516 492 467 467
query44 1124 683 696 683
query45 184 173 169 169
query46 1142 630 644 630
query47 1535 1517 1482 1482
query48 390 303 318 303
query49 1118 282 285 282
query50 704 307 320 307
query51 5214 5133 5162 5133
query52 99 72 81 72
query53 324 259 256 256
query54 229 190 190 190
query55 85 86 75 75
query56 178 158 169 158
query57 963 929 917 917
query58 191 157 156 156
query59 2434 2282 2355 2282
query60 203 174 181 174
query61 83 82 82 82
query62 606 348 371 348
query63 278 255 263 255
query64 4719 3755 3456 3456
query65 3263 3248 3237 3237
query66 956 323 313 313
query67 14574 14138 14571 14138
query68 5517 499 520 499
query69 469 307 309 307
query70 1305 1207 1260 1207
query71 323 203 212 203
query72 5999 3111 2812 2812
query73 688 319 319 319
query74 6650 6107 6246 6107
query75 3015 2312 2265 2265
query76 2984 966 931 931
query77 393 234 231 231
query78 9318 8682 8540 8540
query79 2822 520 524 520
query80 2117 321 313 313
query81 498 202 200 200
query82 798 80 85 80
query83 236 117 115 115
query84 296 82 73 73
query85 1990 331 329 329
query86 483 323 273 273
query87 3445 3290 3242 3242
query88 3993 2202 2195 2195
query89 434 356 344 344
query90 1923 189 185 185
query91 148 118 118 118
query92 52 42 41 41
query93 5157 450 426 426
query94 1187 156 160 156
query95 508 448 461 448
query96 637 317 321 317
query97 4262 4135 4118 4118
query98 210 188 184 184
query99 1176 690 678 678
Total cold run time: 279278 ms
Total hot run time: 174451 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1925664774
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 0e513618fe8797934684d7ef17f66c1932a4652a with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.4 seconds inserted 10000000 Rows, about 746K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30730:
URL: https://github.com/apache/doris/pull/30730#discussion_r1474771949
##########
be/test/vec/runtime/ip_value_test.cpp:
##########
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <gtest/gtest-message.h>
Review Comment:
warning: 'gtest/gtest-message.h' file not found [clang-diagnostic-error]
```cpp
#include <gtest/gtest-message.h>
^
```
##########
be/test/vec/runtime/ip_value_test.cpp:
##########
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <gtest/gtest-message.h>
+#include <gtest/gtest-test-part.h>
+
+#include <cstdint>
+#include <iostream>
+
+#include "gtest/gtest_pred_impl.h"
+#include "vec/common/ipv6_to_binary.h"
+#include "vec/runtime/ipv4_value.h"
+#include "vec/runtime/ipv6_value.h"
+
+namespace doris {
+
+class IPv4Value;
+class IPv6Value;
+
+// util function
+template <typename T>
+static void print_bytes(T num) {
+ auto* byte_ptr = reinterpret_cast<uint8_t*>(&num);
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
```suggestion
auto* byte_ptr = reinterpret_cast<uint8_t*>(&num);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1925662622
<details>
<summary>ClickBench: <b>Total hot run time: 30.84 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0e513618fe8797934684d7ef17f66c1932a4652a, data reload: false
query1 0.04 0.03 0.04
query2 0.05 0.02 0.02
query3 0.23 0.06 0.06
query4 1.67 0.10 0.10
query5 0.54 0.51 0.51
query6 1.18 0.64 0.62
query7 0.02 0.01 0.01
query8 0.04 0.02 0.03
query9 0.56 0.49 0.50
query10 0.54 0.56 0.55
query11 0.12 0.08 0.08
query12 0.11 0.08 0.09
query13 0.60 0.61 0.60
query14 0.78 0.79 0.79
query15 0.79 0.77 0.77
query16 0.38 0.35 0.40
query17 1.02 1.04 0.97
query18 0.20 0.28 0.23
query19 1.89 1.73 1.78
query20 0.01 0.01 0.01
query21 15.42 0.57 0.56
query22 2.46 2.28 2.10
query23 17.44 0.84 0.73
query24 2.43 0.72 0.91
query25 0.33 0.18 0.11
query26 0.49 0.14 0.14
query27 0.05 0.05 0.05
query28 12.20 0.84 0.84
query29 12.50 3.10 3.12
query30 0.61 0.61 0.53
query31 2.78 0.36 0.35
query32 3.36 0.48 0.47
query33 3.21 3.20 3.22
query34 15.73 4.33 4.34
query35 4.31 4.32 4.28
query36 1.12 1.05 1.05
query37 0.07 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.01 0.02
query40 0.16 0.13 0.13
query41 0.06 0.01 0.02
query42 0.03 0.01 0.02
query43 0.02 0.02 0.02
Total cold run time: 105.61 s
Total hot run time: 30.84 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #30730:
URL: https://github.com/apache/doris/pull/30730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30730:
URL: https://github.com/apache/doris/pull/30730#discussion_r1474762314
##########
be/test/vec/runtime/ip_value_test.cpp:
##########
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <gtest/gtest-message.h>
+#include <gtest/gtest-test-part.h>
+
+#include <iostream>
+#include <cstdint>
+
+#include "gtest/gtest_pred_impl.h"
+#include "vec/common/ipv6_to_binary.h"
+#include "vec/runtime/ipv4_value.h"
+#include "vec/runtime/ipv6_value.h"
+
+namespace doris {
+
+class IPv4Value;
+class IPv6Value;
+
+// util function
+template <typename T>
+static void print_bytes(T num) {
+ uint8_t* byte_ptr = reinterpret_cast<uint8_t*>(&num);
+
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
```suggestion
auto* byte_ptr = reinterpret_cast<uint8_t*>(&num);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "sjyango (via GitHub)" <gi...@apache.org>.
sjyango commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1921746400
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1921913154
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 5ed1be9d1179c3347f41b3a8996bef9c031c00dd with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.5 seconds inserted 10000000 Rows, about 740K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30730:
URL: https://github.com/apache/doris/pull/30730#discussion_r1477184692
##########
be/src/vec/functions/function_ip.h:
##########
@@ -360,8 +369,8 @@ class FunctionIPv6NumToString : public IFunction {
namespace detail {
template <IPConvertExceptionMode exception_mode, typename ToColumn = ColumnIPv6,
typename StringColumnType>
-ColumnPtr convertToIPv6(const StringColumnType& string_column,
- const PaddedPODArray<UInt8>* null_map = nullptr) {
+ColumnPtr convert_to_ipv6(const StringColumnType& string_column,
Review Comment:
warning: function 'convert_to_ipv6' exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
ColumnPtr convert_to_ipv6(const StringColumnType& string_column,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/functions/function_ip.h:371:** 144 lines including whitespace and comments (threshold 80)
```cpp
ColumnPtr convert_to_ipv6(const StringColumnType& string_column,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "sjyango (via GitHub)" <gi...@apache.org>.
sjyango commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1925631921
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1925656639
<details>
<summary>TPC-H: <b>Total hot run time: 36911 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0e513618fe8797934684d7ef17f66c1932a4652a, data reload: false
------ Round 1 ----------------------------------
q1 17676 4708 4403 4403
q2 2041 140 138 138
q3 10669 938 922 922
q4 4670 701 739 701
q5 7718 2847 2761 2761
q6 180 124 123 123
q7 1148 730 716 716
q8 9287 1991 2036 1991
q9 7732 6403 6387 6387
q10 8118 2437 2421 2421
q11 405 217 198 198
q12 728 277 294 277
q13 18026 3313 3285 3285
q14 280 250 242 242
q15 528 488 495 488
q16 488 401 407 401
q17 939 540 532 532
q18 6781 5956 5900 5900
q19 1571 1458 1396 1396
q20 617 352 337 337
q21 6685 2991 3128 2991
q22 807 301 308 301
Total cold run time: 107094 ms
Total hot run time: 36911 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4456 4429 4371 4371
q2 345 219 238 219
q3 2987 2823 2836 2823
q4 1843 1594 1601 1594
q5 5306 5250 5205 5205
q6 196 114 118 114
q7 2118 1820 1781 1781
q8 3107 3304 3286 3286
q9 8302 8345 8263 8263
q10 5834 3604 3561 3561
q11 543 457 460 457
q12 721 569 567 567
q13 10371 3104 3073 3073
q14 274 251 248 248
q15 538 493 483 483
q16 524 480 480 480
q17 1842 1668 1721 1668
q18 8067 7588 7566 7566
q19 7163 1497 1525 1497
q20 2139 1921 1906 1906
q21 4834 4639 4593 4593
q22 556 464 445 445
Total cold run time: 72066 ms
Total hot run time: 54200 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1925659623
<details>
<summary>TPC-DS: <b>Total hot run time: 173909 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0e513618fe8797934684d7ef17f66c1932a4652a, data reload: false
query1 924 338 330 330
query2 6555 1991 2009 1991
query3 6698 208 211 208
query4 32223 21864 21963 21864
query5 4290 360 418 360
query6 255 163 169 163
query7 4602 296 283 283
query8 248 170 181 170
query9 8834 2321 2319 2319
query10 422 212 226 212
query11 18756 15323 15263 15263
query12 137 75 74 74
query13 1607 428 409 409
query14 9403 6618 6869 6618
query15 239 172 187 172
query16 8069 272 244 244
query17 1843 544 503 503
query18 2103 269 267 267
query19 321 149 144 144
query20 81 76 80 76
query21 198 119 116 116
query22 4986 4845 4631 4631
query23 30630 29905 29893 29893
query24 10388 2715 2722 2715
query25 533 348 335 335
query26 711 139 147 139
query27 2211 297 308 297
query28 5873 1878 1837 1837
query29 879 617 606 606
query30 278 131 141 131
query31 922 720 704 704
query32 90 52 51 51
query33 646 217 224 217
query34 910 455 467 455
query35 877 793 742 742
query36 1052 882 891 882
query37 94 58 63 58
query38 3219 3134 3110 3110
query39 1298 1279 1241 1241
query40 184 94 95 94
query41 39 34 34 34
query42 100 89 93 89
query43 499 490 488 488
query44 1032 686 699 686
query45 199 181 174 174
query46 1064 664 657 657
query47 1623 1425 1522 1425
query48 434 355 355 355
query49 1070 299 282 282
query50 779 369 400 369
query51 5283 5084 5191 5084
query52 102 85 98 85
query53 347 278 279 278
query54 291 220 220 220
query55 80 76 77 76
query56 223 202 201 201
query57 978 907 898 898
query58 203 188 188 188
query59 2630 2590 2472 2472
query60 258 217 212 212
query61 88 89 83 83
query62 648 348 346 346
query63 293 261 270 261
query64 5041 3715 3602 3602
query65 3249 3246 3259 3246
query66 818 309 305 305
query67 14696 14000 14099 14000
query68 5014 534 530 530
query69 472 332 331 331
query70 1228 1230 1238 1230
query71 315 252 257 252
query72 6064 2834 2674 2674
query73 726 314 321 314
query74 6541 6273 6326 6273
query75 3009 2332 2332 2332
query76 3338 964 942 942
query77 390 225 222 222
query78 9775 8452 8605 8452
query79 2840 498 495 495
query80 2084 351 347 347
query81 529 193 195 193
query82 795 79 84 79
query83 255 123 123 123
query84 287 78 79 78
query85 2178 341 336 336
query86 491 292 312 292
query87 3360 3166 3203 3166
query88 3934 2313 2297 2297
query89 453 379 374 374
query90 2000 161 163 161
query91 151 124 141 124
query92 52 46 41 41
query93 3508 471 486 471
query94 1260 178 175 175
query95 8012 360 360 360
query96 594 282 268 268
query97 4205 4100 4143 4100
query98 218 195 191 191
query99 1141 693 646 646
Total cold run time: 290875 ms
Total hot run time: 173909 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1925658604
TeamCity be ut coverage result:
Function Coverage: 36.16% (8626/23855)
Line Coverage: 28.21% (70534/250005)
Region Coverage: 27.23% (36403/133683)
Branch Coverage: 24.02% (18645/77620)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0e513618fe8797934684d7ef17f66c1932a4652a_0e513618fe8797934684d7ef17f66c1932a4652a/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "sjyango (via GitHub)" <gi...@apache.org>.
sjyango commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1923367850
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1921908433
<details>
<summary>ClickBench: <b>Total hot run time: 31.38 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5ed1be9d1179c3347f41b3a8996bef9c031c00dd, data reload: false
query1 0.04 0.03 0.03
query2 0.06 0.02 0.02
query3 0.23 0.06 0.06
query4 1.67 0.09 0.09
query5 0.52 0.51 0.50
query6 1.18 0.64 0.63
query7 0.01 0.01 0.01
query8 0.03 0.03 0.03
query9 0.52 0.52 0.50
query10 0.55 0.55 0.55
query11 0.12 0.08 0.09
query12 0.10 0.09 0.10
query13 0.61 0.61 0.61
query14 0.79 0.82 0.80
query15 0.80 0.77 0.77
query16 0.38 0.37 0.37
query17 0.98 0.99 1.01
query18 0.21 0.28 0.24
query19 1.82 1.77 1.81
query20 0.01 0.00 0.01
query21 15.42 0.56 0.56
query22 2.71 2.50 2.10
query23 17.52 0.82 0.80
query24 2.40 1.11 1.46
query25 0.28 0.31 0.12
query26 0.62 0.14 0.14
query27 0.06 0.03 0.05
query28 11.34 0.83 0.84
query29 12.73 3.14 3.14
query30 0.63 0.55 0.55
query31 2.79 0.35 0.34
query32 3.36 0.48 0.47
query33 3.22 3.23 3.25
query34 15.80 4.31 4.27
query35 4.31 4.24 4.27
query36 1.09 1.05 1.06
query37 0.07 0.05 0.05
query38 0.03 0.03 0.02
query39 0.02 0.02 0.02
query40 0.16 0.13 0.14
query41 0.08 0.01 0.01
query42 0.03 0.02 0.01
query43 0.03 0.02 0.02
Total cold run time: 105.33 s
Total hot run time: 31.38 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1925755742
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1923499706
TeamCity be ut coverage result:
Function Coverage: 36.17% (8628/23853)
Line Coverage: 28.22% (70541/249929)
Region Coverage: 27.24% (36406/133648)
Branch Coverage: 24.02% (18640/77596)
Coverage Report: http://coverage.selectdb-in.cc/coverage/668c08ea82f99cbd0da249ead022113095be3e1a_668c08ea82f99cbd0da249ead022113095be3e1a/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #30730:
URL: https://github.com/apache/doris/pull/30730#discussion_r1477162202
##########
be/src/vec/common/format_ip.h:
##########
@@ -194,15 +194,135 @@ inline bool parseIPv4whole(const char* src, unsigned char* dst) {
return end != nullptr && *end == '\0';
}
+/// integer logarithm, return ceil(log(value, base)) (the smallest integer greater or equal than log(value, base)
+inline constexpr UInt32 intLog(const UInt32 value, const UInt32 base, const bool carry) {
Review Comment:
remove the unless code inline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1921876019
<details>
<summary>TPC-H: <b>Total hot run time: 36991 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5ed1be9d1179c3347f41b3a8996bef9c031c00dd, data reload: false
------ Round 1 ----------------------------------
q1 17635 4544 4422 4422
q2 2039 141 129 129
q3 10599 914 913 913
q4 4682 756 709 709
q5 7690 2880 2730 2730
q6 188 117 117 117
q7 1148 738 710 710
q8 9269 2035 2025 2025
q9 7666 6356 6337 6337
q10 8081 2494 2467 2467
q11 406 219 201 201
q12 754 287 281 281
q13 18047 3304 3287 3287
q14 281 265 251 251
q15 529 487 489 487
q16 480 418 408 408
q17 936 593 543 543
q18 6831 5932 5929 5929
q19 1566 1480 1382 1382
q20 622 362 349 349
q21 6731 3012 3158 3012
q22 805 303 302 302
Total cold run time: 106985 ms
Total hot run time: 36991 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4602 4434 4459 4434
q2 339 244 237 237
q3 2994 2828 2834 2828
q4 1878 1605 1660 1605
q5 5213 5279 5208 5208
q6 191 114 112 112
q7 2196 1781 1833 1781
q8 3128 3210 3270 3210
q9 8353 8270 8317 8270
q10 5962 3606 3588 3588
q11 543 458 458 458
q12 732 571 579 571
q13 11139 3111 3056 3056
q14 281 275 267 267
q15 528 490 487 487
q16 506 488 477 477
q17 1871 1679 1699 1679
q18 8078 7691 7548 7548
q19 8982 1562 1557 1557
q20 2146 1904 1900 1900
q21 4827 4575 4630 4575
q22 556 480 463 463
Total cold run time: 75045 ms
Total hot run time: 54311 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1923518028
<details>
<summary>ClickBench: <b>Total hot run time: 30.55 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 668c08ea82f99cbd0da249ead022113095be3e1a, data reload: false
query1 0.03 0.03 0.02
query2 0.06 0.02 0.02
query3 0.23 0.06 0.06
query4 1.68 0.10 0.10
query5 0.53 0.52 0.51
query6 1.24 0.65 0.64
query7 0.02 0.01 0.01
query8 0.04 0.02 0.02
query9 0.56 0.51 0.51
query10 0.55 0.55 0.56
query11 0.12 0.08 0.08
query12 0.10 0.08 0.09
query13 0.59 0.60 0.61
query14 0.79 0.80 0.79
query15 0.80 0.77 0.77
query16 0.38 0.41 0.38
query17 1.01 0.98 1.04
query18 0.22 0.26 0.24
query19 1.89 1.77 1.79
query20 0.02 0.01 0.01
query21 15.40 0.59 0.56
query22 2.47 2.53 1.94
query23 17.14 1.05 0.85
query24 3.09 0.35 1.61
query25 0.32 0.13 0.12
query26 0.65 0.15 0.14
query27 0.06 0.05 0.04
query28 11.28 0.86 0.83
query29 12.52 3.25 3.19
query30 0.63 0.59 0.54
query31 2.78 0.33 0.36
query32 3.37 0.49 0.48
query33 3.21 3.23 3.22
query34 15.78 4.25 4.25
query35 4.34 4.29 4.26
query36 1.11 1.05 1.06
query37 0.07 0.05 0.05
query38 0.03 0.03 0.03
query39 0.02 0.02 0.01
query40 0.16 0.13 0.13
query41 0.07 0.02 0.01
query42 0.02 0.01 0.02
query43 0.02 0.02 0.02
Total cold run time: 105.4 s
Total hot run time: 30.55 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1923507159
<details>
<summary>TPC-DS: <b>Total hot run time: 174091 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 668c08ea82f99cbd0da249ead022113095be3e1a, data reload: false
query1 919 339 329 329
query2 6561 1954 1980 1954
query3 6697 204 207 204
query4 31869 22201 22053 22053
query5 4242 365 434 365
query6 246 168 164 164
query7 4598 288 280 280
query8 247 173 177 173
query9 9289 2276 2247 2247
query10 407 214 223 214
query11 18306 15417 15292 15292
query12 123 77 75 75
query13 1619 408 428 408
query14 9657 7209 6923 6923
query15 303 179 182 179
query16 8150 258 244 244
query17 2091 539 501 501
query18 2099 265 266 265
query19 361 137 138 137
query20 83 72 81 72
query21 195 124 126 124
query22 4821 4584 4682 4584
query23 31131 30081 29999 29999
query24 10536 2701 2761 2701
query25 570 356 338 338
query26 1079 145 154 145
query27 2356 302 300 300
query28 7119 1839 1824 1824
query29 890 616 614 614
query30 281 132 140 132
query31 918 702 706 702
query32 91 53 47 47
query33 734 218 213 213
query34 1108 452 466 452
query35 869 753 733 733
query36 1092 928 900 900
query37 112 59 60 59
query38 3225 3070 3133 3070
query39 1294 1250 1247 1247
query40 184 96 95 95
query41 36 36 34 34
query42 96 87 96 87
query43 523 490 488 488
query44 1094 680 697 680
query45 191 185 177 177
query46 1053 670 657 657
query47 1518 1505 1515 1505
query48 429 344 361 344
query49 1075 291 292 291
query50 780 385 380 380
query51 5300 5091 5105 5091
query52 104 87 85 85
query53 330 270 275 270
query54 289 218 232 218
query55 78 75 78 75
query56 225 200 200 200
query57 981 903 857 857
query58 206 179 183 179
query59 2465 2318 2402 2318
query60 242 213 214 213
query61 85 86 89 86
query62 681 354 352 352
query63 303 279 279 279
query64 5162 3525 3569 3525
query65 3275 3251 3225 3225
query66 818 293 303 293
query67 14374 13884 14016 13884
query68 4499 530 521 521
query69 472 345 328 328
query70 1283 1227 1207 1207
query71 320 252 251 251
query72 6085 2840 2672 2672
query73 701 322 330 322
query74 6657 6207 6257 6207
query75 3048 2331 2322 2322
query76 3025 982 943 943
query77 359 230 230 230
query78 9153 8710 8564 8564
query79 4465 502 497 497
query80 1805 353 353 353
query81 542 201 197 197
query82 1130 83 77 77
query83 291 129 123 123
query84 286 87 74 74
query85 2073 341 326 326
query86 476 293 287 287
query87 3438 3208 3169 3169
query88 4727 2359 2341 2341
query89 482 351 361 351
query90 2072 164 168 164
query91 160 123 124 123
query92 56 44 45 44
query93 5376 485 480 480
query94 1277 175 171 171
query95 474 7976 367 367
query96 615 282 270 270
query97 4274 4128 4099 4099
query98 221 196 196 196
query99 1160 704 664 664
Total cold run time: 289187 ms
Total hot run time: 174091 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ip) change IPv6 to little-endian byte order storage (like IPv4) [doris]
Posted by "sjyango (via GitHub)" <gi...@apache.org>.
sjyango commented on PR #30730:
URL: https://github.com/apache/doris/pull/30730#issuecomment-1925597116
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org