You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/08 23:06:49 UTC

[GitHub] [spark] xinrong-databricks commented on a change in pull request #34225: [SPARK-36885][PYTHON] Inline type hints for pyspark.sql.dataframe

xinrong-databricks commented on a change in pull request #34225:
URL: https://github.com/apache/spark/pull/34225#discussion_r725369409



##########
File path: python/pyspark/__init__.pyi
##########
@@ -71,7 +71,7 @@ def since(version: Union[str, float]) -> Callable[[T], T]: ...
 def copy_func(
     f: F,
     name: Optional[str] = ...,
-    sinceversion: Optional[str] = ...,
+    sinceversion: Optional[Union[str, float]] = ...,

Review comment:
       Great! My ongoing PR needs the change as well! 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org