You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Brock Noland (Created) (JIRA)" <ji...@apache.org> on 2012/02/29 03:23:57 UTC
[jira] [Created] (FLUME-1009) HDFSEventSink should return BACKOFF
when the channel returns null
HDFSEventSink should return BACKOFF when the channel returns null
-----------------------------------------------------------------
Key: FLUME-1009
URL: https://issues.apache.org/jira/browse/FLUME-1009
Project: Flume
Issue Type: Bug
Reporter: Brock Noland
As discussed here sinks should return BACKOFF is there is nothing in the channel.
http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLUME-1009) HDFSEventSink should return BACKOFF
when the channel returns null
Posted by "Arvind Prabhakar (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar reassigned FLUME-1009:
---------------------------------------
Assignee: Brock Noland
> HDFSEventSink should return BACKOFF when the channel returns null
> -----------------------------------------------------------------
>
> Key: FLUME-1009
> URL: https://issues.apache.org/jira/browse/FLUME-1009
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Priority: Blocker
> Fix For: v1.1.0
>
> Attachments: FLUME-1009-0.patch
>
>
> As discussed here sinks should return BACKOFF is there is nothing in the channel.
> http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
> In conjunction with JDBCChannel, Flume will burn an entire CPU doing nothing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1009) HDFSEventSink should return BACKOFF
when the channel returns null
Posted by "Juhani Connolly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juhani Connolly updated FLUME-1009:
-----------------------------------
Fix Version/s: v1.1.0
> HDFSEventSink should return BACKOFF when the channel returns null
> -----------------------------------------------------------------
>
> Key: FLUME-1009
> URL: https://issues.apache.org/jira/browse/FLUME-1009
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Priority: Blocker
> Fix For: v1.1.0
>
>
> As discussed here sinks should return BACKOFF is there is nothing in the channel.
> http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
> In conjunction with JDBCChannel, Flume will burn an entire CPU doing nothing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1009) HDFSEventSink should return BACKOFF
when the channel returns null
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219687#comment-13219687 ]
jiraposter@reviews.apache.org commented on FLUME-1009:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4104/#review5474
-----------------------------------------------------------
Ship it!
Simple and does the job it's expected to do!
- Juhani
On 2012-02-29 09:57:00, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4104/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-29 09:57:00)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HDFSEventSink returns BACKOFF if the channel returns null. Added UNIT test to avoid regression.
bq.
bq.
bq. This addresses bug FLUME-1009.
bq. https://issues.apache.org/jira/browse/FLUME-1009
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 524b69c
bq. flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java 7d8ee8a
bq.
bq. Diff: https://reviews.apache.org/r/4104/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> HDFSEventSink should return BACKOFF when the channel returns null
> -----------------------------------------------------------------
>
> Key: FLUME-1009
> URL: https://issues.apache.org/jira/browse/FLUME-1009
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Priority: Blocker
>
> As discussed here sinks should return BACKOFF is there is nothing in the channel.
> http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
> In conjunction with JDBCChannel, Flume will burn an entire CPU doing nothing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FLUME-1009) HDFSEventSink should return BACKOFF
when the channel returns null
Posted by "Arvind Prabhakar (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar resolved FLUME-1009.
-------------------------------------
Resolution: Fixed
Patch committed. Thanks Brock!
> HDFSEventSink should return BACKOFF when the channel returns null
> -----------------------------------------------------------------
>
> Key: FLUME-1009
> URL: https://issues.apache.org/jira/browse/FLUME-1009
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Priority: Blocker
> Fix For: v1.1.0
>
> Attachments: FLUME-1009-0.patch
>
>
> As discussed here sinks should return BACKOFF is there is nothing in the channel.
> http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
> In conjunction with JDBCChannel, Flume will burn an entire CPU doing nothing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1009) HDFSEventSink should return BACKOFF
when the channel returns null
Posted by "Juhani Connolly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223895#comment-13223895 ]
Juhani Connolly commented on FLUME-1009:
----------------------------------------
Can you attach the patch so we can push this to version control?
> HDFSEventSink should return BACKOFF when the channel returns null
> -----------------------------------------------------------------
>
> Key: FLUME-1009
> URL: https://issues.apache.org/jira/browse/FLUME-1009
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Priority: Blocker
> Fix For: v1.1.0
>
>
> As discussed here sinks should return BACKOFF is there is nothing in the channel.
> http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
> In conjunction with JDBCChannel, Flume will burn an entire CPU doing nothing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1009) HDFSEventSink should return BACKOFF
when the channel returns null
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219048#comment-13219048 ]
jiraposter@reviews.apache.org commented on FLUME-1009:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4104/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
HDFSEventSink returns BACKOFF if the channel returns null. Added UNIT test to avoid regression.
This addresses bug FLUME-1009.
https://issues.apache.org/jira/browse/FLUME-1009
Diffs
-----
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 524b69c
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java 7d8ee8a
Diff: https://reviews.apache.org/r/4104/diff
Testing
-------
All unit tests pass.
Thanks,
Brock
> HDFSEventSink should return BACKOFF when the channel returns null
> -----------------------------------------------------------------
>
> Key: FLUME-1009
> URL: https://issues.apache.org/jira/browse/FLUME-1009
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Priority: Blocker
>
> As discussed here sinks should return BACKOFF is there is nothing in the channel.
> http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
> In conjunction with JDBCChannel, Flume will burn an entire CPU doing nothing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1009) HDFSEventSink should return BACKOFF
when the channel returns null
Posted by "Juhani Connolly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227298#comment-13227298 ]
Juhani Connolly commented on FLUME-1009:
----------------------------------------
I tried to commit this but I think commit karma hasn't gone through yet(or I could just be screwing something up)
Could someone put it through... It'd be nice if HDFSEventSink wasn't just grinding away without data to process...
> HDFSEventSink should return BACKOFF when the channel returns null
> -----------------------------------------------------------------
>
> Key: FLUME-1009
> URL: https://issues.apache.org/jira/browse/FLUME-1009
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Priority: Blocker
> Fix For: v1.1.0
>
> Attachments: FLUME-1009-0.patch
>
>
> As discussed here sinks should return BACKOFF is there is nothing in the channel.
> http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
> In conjunction with JDBCChannel, Flume will burn an entire CPU doing nothing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1009) HDFSEventSink should return BACKOFF
when the channel returns null
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227303#comment-13227303 ]
jiraposter@reviews.apache.org commented on FLUME-1009:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4104/#review5834
-----------------------------------------------------------
Ship it!
+1
- Arvind
On 2012-02-29 09:57:00, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4104/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-29 09:57:00)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HDFSEventSink returns BACKOFF if the channel returns null. Added UNIT test to avoid regression.
bq.
bq.
bq. This addresses bug FLUME-1009.
bq. https://issues.apache.org/jira/browse/FLUME-1009
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 524b69c
bq. flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java 7d8ee8a
bq.
bq. Diff: https://reviews.apache.org/r/4104/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> HDFSEventSink should return BACKOFF when the channel returns null
> -----------------------------------------------------------------
>
> Key: FLUME-1009
> URL: https://issues.apache.org/jira/browse/FLUME-1009
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Priority: Blocker
> Fix For: v1.1.0
>
> Attachments: FLUME-1009-0.patch
>
>
> As discussed here sinks should return BACKOFF is there is nothing in the channel.
> http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
> In conjunction with JDBCChannel, Flume will burn an entire CPU doing nothing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1009) HDFSEventSink should return BACKOFF
when the channel returns null
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-1009:
--------------------------------
Attachment: FLUME-1009-0.patch
Patch attached.
> HDFSEventSink should return BACKOFF when the channel returns null
> -----------------------------------------------------------------
>
> Key: FLUME-1009
> URL: https://issues.apache.org/jira/browse/FLUME-1009
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Priority: Blocker
> Fix For: v1.1.0
>
> Attachments: FLUME-1009-0.patch
>
>
> As discussed here sinks should return BACKOFF is there is nothing in the channel.
> http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
> In conjunction with JDBCChannel, Flume will burn an entire CPU doing nothing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1009) HDFSEventSink should return BACKOFF
when the channel returns null
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-1009:
--------------------------------
Component/s: Sinks+Sources
Description:
As discussed here sinks should return BACKOFF is there is nothing in the channel.
http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
In conjunction with JDBCChannel, Flume will burn an entire CPU doing nothing.
was:
As discussed here sinks should return BACKOFF is there is nothing in the channel.
http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
Priority: Blocker (was: Major)
Affects Version/s: v1.0.0
> HDFSEventSink should return BACKOFF when the channel returns null
> -----------------------------------------------------------------
>
> Key: FLUME-1009
> URL: https://issues.apache.org/jira/browse/FLUME-1009
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Priority: Blocker
>
> As discussed here sinks should return BACKOFF is there is nothing in the channel.
> http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201202.mbox/%3CCAFukC%3D7Dj7%3DcP%2BzLKzu8jUAb0Y-A-Faw-_Gix0mcV-V%2B-QBZ0A%40mail.gmail.com%3E
> In conjunction with JDBCChannel, Flume will burn an entire CPU doing nothing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira