You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/04 16:48:43 UTC

[GitHub] [beam] nikie commented on pull request #15901: BEAM-13189 Python TextIO: add escapechar feature.

nikie commented on pull request #15901:
URL: https://github.com/apache/beam/pull/15901#issuecomment-961227561


   R: @dmitriikuzinepam 
   R: @tvalentyn 
   Unfortunately this adds even more `if/else` blocks for each default case line splitting which may affect performance.
   
   In this regard, I can propose to move custom delimiter and escapechar features handling into a separate `_find_separator_bounds` method, return the old one (before these features) and choose between them in the init based on the source params. This would result in code duplication, but the old method was quite short and as long as all cases are covered with unit tests, this could be considered...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org