You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/27 09:12:01 UTC

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11432: feat: annotation layers CRUD list view

dpgaspar commented on a change in pull request #11432:
URL: https://github.com/apache/incubator-superset/pull/11432#discussion_r512523630



##########
File path: superset/annotation_layers/api.py
##########
@@ -86,7 +88,9 @@ class AnnotationLayerRestApi(BaseSupersetModelRestApi):
         "descr",
         "created_by.first_name",
         "changed_by.first_name",
+        "changed_on",
         "changed_on_delta_humanized",
+        "created_on",

Review comment:
       Why do we need `changed_on`? it's better to use `changed_on_delta_humanized`, also if we need/want `created_on` we should add a `created_on_delta_humanized`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org