You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by hw...@apache.org on 2012/02/21 06:20:18 UTC
svn commit: r1291603 - in /subversion/trunk/subversion/libsvn_ra_neon:
commit.c ra_neon.h session.c util.c
Author: hwright
Date: Tue Feb 21 05:20:18 2012
New Revision: 1291603
URL: http://svn.apache.org/viewvc?rev=1291603&view=rev
Log:
Fix test breakage over ra_neon as a result of r1291593, by implementing the
shim callback registration function for ra_neon.
Note: I don't have a neon build environment on this box, so this is somewhat
of a shot in the dark.
* subversion/libsvn_ra_neon/util.c
(svn_ra_neon__register_editor_shim_callbacks): New.
* subversion/libsvn_ra_neon/session.c
(neon_vtable): Add additional function.
* subversion/libsvn_ra_neon/ra_neon.h
(svn_ra_neon__session_t): Add shim_callbacks member.
(svn_ra_neon__register_editor_shim_callbacks): New.
* subversion/libsvn_ra_neon/commit.c
(svn_ra_neon__get_commit_editor): Use the registered callbacks.
Modified:
subversion/trunk/subversion/libsvn_ra_neon/commit.c
subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h
subversion/trunk/subversion/libsvn_ra_neon/session.c
subversion/trunk/subversion/libsvn_ra_neon/util.c
Modified: subversion/trunk/subversion/libsvn_ra_neon/commit.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/commit.c?rev=1291603&r1=1291602&r2=1291603&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/commit.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/commit.c Tue Feb 21 05:20:18 2012
@@ -1570,8 +1570,6 @@ svn_error_t * svn_ra_neon__get_commit_ed
svn_delta_editor_t *commit_editor;
commit_ctx_t *cc;
apr_hash_index_t *hi;
- svn_delta_shim_callbacks_t *shim_callbacks =
- svn_delta_shim_callbacks_default(pool);
/* Build the main commit editor's baton. */
cc = apr_pcalloc(pool, sizeof(*cc));
@@ -1622,7 +1620,7 @@ svn_error_t * svn_ra_neon__get_commit_ed
*edit_baton = cc;
SVN_ERR(svn_editor__insert_shims(editor, edit_baton, *editor, *edit_baton,
- shim_callbacks, pool, pool));
+ ras->shim_callbacks, pool, pool));
return SVN_NO_ERROR;
}
Modified: subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h?rev=1291603&r1=1291602&r2=1291603&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h Tue Feb 21 05:20:18 2012
@@ -131,6 +131,9 @@ typedef struct svn_ra_neon__session_t {
deadprop-count property.*/
svn_tristate_t supports_deadprop_count;
+ /* Ev2 shim callbacks. */
+ svn_delta_shim_callbacks_t *shim_callbacks;
+
/*** HTTP v2 protocol stuff. ***
*
* We assume that if mod_dav_svn sends one of the special v2 OPTIONs
@@ -1181,6 +1184,10 @@ svn_ra_neon__get_deadprop_count_support(
const char *final_url,
apr_pool_t *pool);
+svn_error_t *
+svn_ra_neon__register_editor_shim_callbacks(svn_ra_session_t *session,
+ svn_delta_shim_callbacks_t *callbacks);
+
#ifdef __cplusplus
}
#endif /* __cplusplus */
Modified: subversion/trunk/subversion/libsvn_ra_neon/session.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/session.c?rev=1291603&r1=1291602&r2=1291603&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/session.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/session.c Tue Feb 21 05:20:18 2012
@@ -1229,7 +1229,8 @@ static const svn_ra__vtable_t neon_vtabl
svn_ra_neon__replay,
svn_ra_neon__has_capability,
svn_ra_neon__replay_range,
- svn_ra_neon__get_deleted_rev
+ svn_ra_neon__get_deleted_rev,
+ svn_ra_neon__register_editor_shim_callbacks
};
svn_error_t *
Modified: subversion/trunk/subversion/libsvn_ra_neon/util.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/util.c?rev=1291603&r1=1291602&r2=1291603&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/util.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/util.c Tue Feb 21 05:20:18 2012
@@ -1649,3 +1649,13 @@ svn_ra_neon__get_deadprop_count_support(
return SVN_NO_ERROR;
}
+
+svn_error_t *
+svn_ra_neon__register_editor_shim_callbacks(svn_ra_session_t *session,
+ svn_delta_shim_callbacks_t *callbacks)
+{
+ svn_ra_neon__session_t *ras = session->priv;
+
+ ras->shim_callbacks = callbacks;
+ return SVN_NO_ERROR;
+}