[GitHub] [hadoop] bteke commented on a diff in pull request #5201: YARN-11393. Fs2cs could be extended to set ULF to -1 upon conversion

[GitBox <gi...@apache.org>]

bteke commented on code in PR #5201:
URL: https://github.com/apache/hadoop/pull/5201#discussion_r1055268220


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverter.java:
##########
@@ -185,6 +186,20 @@ public void testDefaultMaxAMShare() throws Exception {
         conf.get(PREFIX + "root.users.joe maximum-am-resource-percent"));
   }
 
+  @Test
+  public void testDefaultUserLimitFactor() throws Exception {
+    converter.convert(config);
+
+    Configuration conf = converter.getCapacitySchedulerConfig();
+    String userLimitFactor =
+            conf.get(PREFIX + "root.default." + USER_LIMIT_FACTOR);
+
+    assertEquals("Default user limit factor", "-1.0", userLimitFactor);
+
+    assertNull("root.users.joe user-limit-factor should be null",
+            conf.get(PREFIX + "root.users.joe user-limit-factor"));

Review Comment:
   This should be -1 as well (if root.users.joe is an existing static queue).



##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSConfigToCSConfigConverter.java:
##########
@@ -412,6 +414,14 @@ private void emitDefaultMaxAMShare() {
           queueMaxAMShareDefault);
     }
   }
+
+  private void emitDefaultUserLimitFactor() {
+    capacitySchedulerConfig.setFloat(
+            CapacitySchedulerConfiguration.
+                    PREFIX + "root.default." + USER_LIMIT_FACTOR,

Review Comment:
   There might be other queues besides the default one which also need to have the default user-limit-factor. Can you please address that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org