[GitHub] [incubator-doris] imay commented on a change in pull request #2144: Fix string type column zone map bug

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2144: Fix string type column zone map bug
URL: https://github.com/apache/incubator-doris/pull/2144#discussion_r343123092
 
 

 ##########
 File path: be/src/olap/schema.h
 ##########
 @@ -99,7 +99,7 @@ class Schema {
     ~Schema();
 
     const std::vector<Field*>& columns() const { return _cols; }
-    const Field* column(ColumnId cid) const { return _cols[cid]; }
+    Field* column(ColumnId cid) const { return _cols[cid]; }
 
 Review comment:
   Why we return a non-const Field? I think this field will be not changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org