You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/10/05 03:25:39 UTC
Review Request 14507: Added put function to hashmap and fixed values() to
return list.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14507/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Repository: mesos-git
Description
-------
Needed this for authentication (see https://reviews.apache.org/r/14292/) in the master.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am e8561dff4e85df88ef5e2362ad054d1cc209d546
3rdparty/libprocess/3rdparty/stout/Makefile.am 0428aa88bd9049212628dc65f7585b86aa35933e
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp cea69889784caa6c527a857c37620da035220beb
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/14507/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 14507: Added put function to hashmap and fixed values()
to return list.
Posted by Vinod Kone <vi...@gmail.com>.
> On Oct. 7, 2013, 6:33 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/Makefile.am, line 124
> > <https://reviews.apache.org/r/14507/diff/1/?file=361606#file361606line124>
> >
> > You'll need to split this into a separate review for the libprocess change.
good call. done!
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14507/#review26742
-----------------------------------------------------------
On Oct. 5, 2013, 1:25 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14507/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2013, 1:25 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Needed this for authentication (see https://reviews.apache.org/r/14292/) in the master.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e8561dff4e85df88ef5e2362ad054d1cc209d546
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 0428aa88bd9049212628dc65f7585b86aa35933e
> 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp cea69889784caa6c527a857c37620da035220beb
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14507/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14507: Added put function to hashmap and fixed values()
to return list.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14507/#review26742
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/Makefile.am
<https://reviews.apache.org/r/14507/#comment52053>
You'll need to split this into a separate review for the libprocess change.
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp
<https://reviews.apache.org/r/14507/#comment52054>
s/set/list/
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp
<https://reviews.apache.org/r/14507/#comment52055>
kill TODO :)
- Ben Mahler
On Oct. 5, 2013, 1:25 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14507/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2013, 1:25 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Needed this for authentication (see https://reviews.apache.org/r/14292/) in the master.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e8561dff4e85df88ef5e2362ad054d1cc209d546
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 0428aa88bd9049212628dc65f7585b86aa35933e
> 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp cea69889784caa6c527a857c37620da035220beb
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14507/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14507: Added put function to hashmap and fixed values()
to return list.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14507/
-----------------------------------------------------------
(Updated Oct. 8, 2013, 11:22 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
bens'.
Repository: mesos-git
Description
-------
Needed this for authentication (see https://reviews.apache.org/r/14292/) in the master.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 0428aa88bd9049212628dc65f7585b86aa35933e
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp cea69889784caa6c527a857c37620da035220beb
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/14507/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 14507: Added put function to hashmap and fixed values()
to return list.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14507/#review26754
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp
<https://reviews.apache.org/r/14507/#comment52076>
s/Key,Value/Key, Value/
- Benjamin Hindman
On Oct. 5, 2013, 1:25 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14507/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2013, 1:25 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Needed this for authentication (see https://reviews.apache.org/r/14292/) in the master.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e8561dff4e85df88ef5e2362ad054d1cc209d546
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 0428aa88bd9049212628dc65f7585b86aa35933e
> 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp cea69889784caa6c527a857c37620da035220beb
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14507/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>