You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/13 04:33:18 UTC
[GitHub] [spark] tianhanhu opened a new pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
tianhanhu opened a new pull request #35187:
URL: https://github.com/apache/spark/pull/35187
### What changes were proposed in this pull request?
Add scalastyle check to disable internal use of scala.concurrent.ExecutionContext.Implicits.global.
The reason is that user queries can also use this thread pool, causing competing in resource and starvation. Spark-internal APIs should thus not use the global thread pool.
### Why are the changes needed?
Forbid Spark internal API from using global thread pool
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
PR tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1013397258
@tianhanhu could you check the test failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1011790307
Jenkins test this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tianhanhu commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
tianhanhu commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1017014826
Just re-enabled workflow. Thanks for the catch @HyukjinKwon :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1016984285
cc @HyukjinKwon can you help determine why the build workflow failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1016993279
Oh I see. looks like the main build job got disabled:
Would have to be enabled manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile removed a comment on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
gatorsmile removed a comment on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1016967348
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1016988272
Thanks for cc'ing me @jiangxb1987. @tianhanhu, Jenkins reached EOL so Apache Spark currently relies on GitHub Actions. Due to the lack of resources allocated to Apache repositories, we leverage the resources from the GitHub Actions' resources from PR author's forked repository (see https://github.com/apache/spark/pull/35187/checks?check_run_id=4875424398).
Would you mind enabling GitHub Actions in your forked repository? After that, we will have to rebase to trigger the build again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 closed pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
jiangxb1987 closed pull request #35187:
URL: https://github.com/apache/spark/pull/35187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1020511440
Thanks, merged to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 closed pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
jiangxb1987 closed pull request #35187:
URL: https://github.com/apache/spark/pull/35187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tianhanhu commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
tianhanhu commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1016991991
@HyukjinKwon I do have actions all allowed for my forked Spark, and I just did the rebase...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tianhanhu commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
tianhanhu commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1016934693
Jenkins test this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1016967348
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1020511440
Thanks, merged to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1012139533
Looks OK if tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1016993279
Oh I see. looks like the main build job got disabled (https://github.com/tianhanhu/spark/actions/workflows/build_and_test.yml):
Would have to be enabled manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35187: [SPARK-37891][CORE] Add scalastyle check to disable scala.concurrent.ExecutionContext.Implicits.global
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35187:
URL: https://github.com/apache/spark/pull/35187#issuecomment-1017026560
@tianhanhu would need to rebase again .. :-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org