You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by Patrick Linskey <pl...@gmail.com> on 2010/02/11 19:15:37 UTC
openjpa.jdbc.QuerySQLCache property
Hi,
Is this out there in a released version yet? If not, I'd like to
propose changing the name to openjpa.QueryStatementCache or merge it
with the QueryCompilationCache or do something less JDBC-specific in
the kernel.
I'm working on a non-relational plug-in to OpenJPA, and the
encroachment of JDBC into the core kernel is causing some problems
here and there.
Incidentally, one of my changes is to create a default no-op
implementation of the query statement cache, to avoid some NPEs.
-Patrick
--
Patrick Linskey
202 669 5907
Re: openjpa.jdbc.QuerySQLCache property
Posted by Kevin Sutter <kw...@gmail.com>.
Hi Patrick,
Yes, the QuerySQLCache property was first into the 1.2.x stream and the
functionality has been improved in the 2.0.x stream. So, changing the name
might be difficult... We've thought about an overall uber-optimization or
uber-cache property that would enable all of the associated caches. But,
just merging one with another probably wouldn't fly with existing customers.
Kevin
On Thu, Feb 11, 2010 at 12:15 PM, Patrick Linskey <pl...@gmail.com>wrote:
> Hi,
>
> Is this out there in a released version yet? If not, I'd like to propose
> changing the name to openjpa.QueryStatementCache or merge it with the
> QueryCompilationCache or do something less JDBC-specific in the kernel.
>
> I'm working on a non-relational plug-in to OpenJPA, and the encroachment of
> JDBC into the core kernel is causing some problems here and there.
>
> Incidentally, one of my changes is to create a default no-op implementation
> of the query statement cache, to avoid some NPEs.
>
> -Patrick
>
> --
> Patrick Linskey
> 202 669 5907
>
>
Re: openjpa.jdbc.QuerySQLCache property
Posted by Patrick Linskey <pl...@gmail.com>.
Cool, thanks, committed.
-Patrick
On Feb 12, 2010, at 5:30 AM, Donald Woods wrote:
> The 1.3.x branch and Trunk are open for commits, while 1.0.x and 1.2.x
> require approval from Mike Dick as the release manager.
>
> I took a quick look at the 1507 patch and it looks good to me.
>
>
> -Donald
>
>
> On 2/11/10 10:28 PM, Patrick Linskey wrote:
>> Cool... I think that it might be possible to do some sort of
>> deprecation. I'll take a look one of these days.
>>
>> Meanwhile, how are we committing fixes these days? I've got a fix for
>> OPENJPA-1507; what's the process?
>>
>> -Patrick
>>
>> On Feb 11, 2010, at 1:30 PM, Pinaki Poddar wrote:
>>
>>>
>>> Actually openjpa.jdbc.QuerySQLCache is a poor naming choice. That
>>> name
>>> openjpa.jdbc.QuerySQLCache originated from a rationale that the
>>> currently
>>> existing technique is a replacement of a previous implementation.
>>> But
>>> that
>>> rationale is technically incorrect.
>>>
>>> I had preferred and proposed a more appropriate name such as
>>> openjpa.PreparedQueryCache (without any jdbc reference to the name
>>> --
>>> because technically the current implementation is a kernel-aware
>>> artifact --
>>> with a JDBC specific implementation). But I had not been able to
>>> find a
>>> solution without replacing/removing the previous implementation
>>> altogether,
>>> and hence to concede that poor naming suggestion. Caching
>>> technique/stratgey
>>> used for the latest implementation is so very different than the
>>> previous
>>> one that considering it as replacement will be a factual error.
>>>
>>>
>>>
>>>
>>>
>>> -----
>>> Pinaki
>>> --
>>> View this message in context:
>>> http://n2.nabble.com/openjpa-jdbc-QuerySQLCache-property-tp4556392p4557587.html
>>>
>>> Sent from the OpenJPA Developers mailing list archive at Nabble.com.
>>
--
Patrick Linskey
202 669 5907
Re: openjpa.jdbc.QuerySQLCache property
Posted by Pinaki Poddar <pp...@apache.org>.
A notion of equivalent keys were added [1] to address the new parameters such
as "javax.persistence.jdbc.driver" that already had a OpenJPA counterpart.
That mechanics may be a possibility to rename "openjpa.jdbc.QuerySQLCache"
to "openjpa.PreparedQueryCache".
[1]
http://openjpa.apache.org/builds/latest/docs/javadoc/org/apache/openjpa/lib/conf/Value.html#addEquivalentKey(java.lang.String)
-----
Pinaki
--
View this message in context: http://n2.nabble.com/openjpa-jdbc-QuerySQLCache-property-tp4556392p4561477.html
Sent from the OpenJPA Developers mailing list archive at Nabble.com.
Re: openjpa.jdbc.QuerySQLCache property
Posted by Donald Woods <dw...@apache.org>.
The 1.3.x branch and Trunk are open for commits, while 1.0.x and 1.2.x
require approval from Mike Dick as the release manager.
I took a quick look at the 1507 patch and it looks good to me.
-Donald
On 2/11/10 10:28 PM, Patrick Linskey wrote:
> Cool... I think that it might be possible to do some sort of
> deprecation. I'll take a look one of these days.
>
> Meanwhile, how are we committing fixes these days? I've got a fix for
> OPENJPA-1507; what's the process?
>
> -Patrick
>
> On Feb 11, 2010, at 1:30 PM, Pinaki Poddar wrote:
>
>>
>> Actually openjpa.jdbc.QuerySQLCache is a poor naming choice. That name
>> openjpa.jdbc.QuerySQLCache originated from a rationale that the currently
>> existing technique is a replacement of a previous implementation. But
>> that
>> rationale is technically incorrect.
>>
>> I had preferred and proposed a more appropriate name such as
>> openjpa.PreparedQueryCache (without any jdbc reference to the name --
>> because technically the current implementation is a kernel-aware
>> artifact --
>> with a JDBC specific implementation). But I had not been able to find a
>> solution without replacing/removing the previous implementation
>> altogether,
>> and hence to concede that poor naming suggestion. Caching
>> technique/stratgey
>> used for the latest implementation is so very different than the previous
>> one that considering it as replacement will be a factual error.
>>
>>
>>
>>
>>
>> -----
>> Pinaki
>> --
>> View this message in context:
>> http://n2.nabble.com/openjpa-jdbc-QuerySQLCache-property-tp4556392p4557587.html
>>
>> Sent from the OpenJPA Developers mailing list archive at Nabble.com.
>
Re: openjpa.jdbc.QuerySQLCache property
Posted by Patrick Linskey <pl...@gmail.com>.
Cool... I think that it might be possible to do some sort of
deprecation. I'll take a look one of these days.
Meanwhile, how are we committing fixes these days? I've got a fix for
OPENJPA-1507; what's the process?
-Patrick
On Feb 11, 2010, at 1:30 PM, Pinaki Poddar wrote:
>
> Actually openjpa.jdbc.QuerySQLCache is a poor naming choice. That name
> openjpa.jdbc.QuerySQLCache originated from a rationale that the
> currently
> existing technique is a replacement of a previous implementation.
> But that
> rationale is technically incorrect.
>
> I had preferred and proposed a more appropriate name such as
> openjpa.PreparedQueryCache (without any jdbc reference to the name --
> because technically the current implementation is a kernel-aware
> artifact --
> with a JDBC specific implementation). But I had not been able to
> find a
> solution without replacing/removing the previous implementation
> altogether,
> and hence to concede that poor naming suggestion. Caching technique/
> stratgey
> used for the latest implementation is so very different than the
> previous
> one that considering it as replacement will be a factual error.
>
>
>
>
>
> -----
> Pinaki
> --
> View this message in context: http://n2.nabble.com/openjpa-jdbc-QuerySQLCache-property-tp4556392p4557587.html
> Sent from the OpenJPA Developers mailing list archive at Nabble.com.
--
Patrick Linskey
202 669 5907
Re: openjpa.jdbc.QuerySQLCache property
Posted by Pinaki Poddar <pp...@apache.org>.
Actually openjpa.jdbc.QuerySQLCache is a poor naming choice. That name
openjpa.jdbc.QuerySQLCache originated from a rationale that the currently
existing technique is a replacement of a previous implementation. But that
rationale is technically incorrect.
I had preferred and proposed a more appropriate name such as
openjpa.PreparedQueryCache (without any jdbc reference to the name --
because technically the current implementation is a kernel-aware artifact --
with a JDBC specific implementation). But I had not been able to find a
solution without replacing/removing the previous implementation altogether,
and hence to concede that poor naming suggestion. Caching technique/stratgey
used for the latest implementation is so very different than the previous
one that considering it as replacement will be a factual error.
-----
Pinaki
--
View this message in context: http://n2.nabble.com/openjpa-jdbc-QuerySQLCache-property-tp4556392p4557587.html
Sent from the OpenJPA Developers mailing list archive at Nabble.com.