You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sohum2002 <gi...@git.apache.org> on 2017/10/07 06:10:19 UTC

[GitHub] spark pull request #19453: Added selectAllColumns function in Dataset class

GitHub user sohum2002 opened a pull request:

    https://github.com/apache/spark/pull/19453

    Added selectAllColumns function in Dataset class

    The proposed two new additional functions is to help select all the columns in a Dataset except for given columns.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sohum2002/spark dataset-selectAllColumns

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19453
    
----
commit 015ac9f31e6b59df41d5827fc1969570ae1b4af3
Author: Sachathamakul, Patrachai (Agoda) <pa...@agoda.com>
Date:   2017-10-07T06:09:32Z

    added selectAllColumns function in Dataset class

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19453: Added selectAllColumns function in Dataset class

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19453
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19453: Added selectAllColumns function in Dataset class

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19453
  
    This sounds identical to `drop`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19453: Added selectAllColumns function in Dataset class

Posted by sohum2002 <gi...@git.apache.org>.
Github user sohum2002 closed the pull request at:

    https://github.com/apache/spark/pull/19453


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19453: Added selectAllColumns function in Dataset class

Posted by sohum2002 <gi...@git.apache.org>.
Github user sohum2002 commented on the issue:

    https://github.com/apache/spark/pull/19453
  
    @srowen - This is a good point, let me close this PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org