[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #916: Optimize the memory usage

[GitBox <gi...@apache.org>]

LaurenceLiZhixin commented on a change in pull request #916:
URL: https://github.com/apache/dubbo-go/pull/916#discussion_r539020716



##########
File path: common/url.go
##########
@@ -427,6 +427,17 @@ func (c *URL) SetParam(key string, value string) {
 	c.params.Set(key, value)
 }
 
+// SetParams will replace the URL.params
+// SetParams will put all key-value pair into url.

Review comment:
       This comment and function not match?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org