You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2023/04/20 08:35:38 UTC
[GitHub] [superset] villebro opened a new pull request, #23747: fix(ace-editor): use monospace fonts by default
villebro opened a new pull request, #23747:
URL: https://github.com/apache/superset/pull/23747
### SUMMARY
Currently the adhoc popovers use a non-monospaced font on Safari, causing misplaced cursors when the statement contains bolded elements. This was not an issue in SQL Lab, which applied a custom font family. This PR moves the SQL Lab font family config into the main ACE Editor component, ensuring that all editors have the same font family.
### AFTER
Now the bolded elements no longer cause the cursor to lag behind:
https://user-images.githubusercontent.com/33317356/233307972-944f9c7b-d5ef-4dfa-89ce-fe090b796185.mp4
SQL Lab is unchanged:
<img width="507" alt="image" src="https://user-images.githubusercontent.com/33317356/233308257-47360741-59c2-4b66-bd28-1e6af1c88055.png">
### BEFORE
Before the cursor would fall behind when there were bolded elements in the statement:
https://user-images.githubusercontent.com/33317356/233308159-ca27972b-c813-4076-8ab4-1aaa358da8c0.mp4
SQL Lab before:
<img width="483" alt="image" src="https://user-images.githubusercontent.com/33317356/233308373-de2ab233-93b1-4b43-8543-0f4bd8a9a224.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23747: fix(ace-editor): use monospace fonts by default
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23747:
URL: https://github.com/apache/superset/pull/23747#issuecomment-1516187803
@villebro Ephemeral environment creation failed. Please check the Actions logs for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23747: fix(ace-editor): use monospace fonts by default
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23747:
URL: https://github.com/apache/superset/pull/23747#issuecomment-1516187779
@villebro Container image not yet published for this PR. Please try again when build is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #23747: fix(ace-editor): use monospace fonts by default
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23747:
URL: https://github.com/apache/superset/pull/23747#issuecomment-1516187091
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #23747: fix(ace-editor): use monospace fonts by default
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #23747:
URL: https://github.com/apache/superset/pull/23747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org