You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "WencongLiu (via GitHub)" <gi...@apache.org> on 2023/05/12 03:01:27 UTC

[GitHub] [flink] WencongLiu opened a new pull request, #22572: [FLINK-29618] Remove Timeout annotation in YARNSessionFIFOSecuredITCase

WencongLiu opened a new pull request, #22572:
URL: https://github.com/apache/flink/pull/22572

   ## What is the purpose of the change
   
   *Remove the timeout annotation in YARNSessionFIFOSecuredITCase to improve the stability.*
   
   
   ## Brief change log
   
     - *Remove the annotation.*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] WencongLiu commented on pull request #22572: [FLINK-29618][yarn-tests] Remove Timeout annotation in YARN-related integration tests

Posted by "WencongLiu (via GitHub)" <gi...@apache.org>.
WencongLiu commented on PR #22572:
URL: https://github.com/apache/flink/pull/22572#issuecomment-1552702594

   @XComp The commit message has been corrected. 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] XComp commented on pull request #22572: [FLINK-29618] Remove Timeout annotation in YARNSessionFIFOSecuredITCase

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22572:
URL: https://github.com/apache/flink/pull/22572#issuecomment-1545304968

   Based on what observation do you conclude that CI is broken? Because [no CI build](https://dev.azure.com/apache-flink/apache-flink/_build?definitionId=2) was picked up since yesterday? :thinking: Or do we have error logs somewhere?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] XComp commented on pull request #22572: [FLINK-29618] Remove Timeout annotation in YARNSessionFIFOSecuredITCase

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22572:
URL: https://github.com/apache/flink/pull/22572#issuecomment-1545210878

   I guess, we could, at least, remove the `@Timeout` from the related `YarnSessionFIFOITCase` as well. WDYT? And what about touching the other tests in `flink-yarn-tests`? Could you check whether it would make sense to remove the timeouts there as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] WencongLiu commented on pull request #22572: [FLINK-29618] Remove Timeout annotation in YARNSessionFIFOSecuredITCase

Posted by "WencongLiu (via GitHub)" <gi...@apache.org>.
WencongLiu commented on PR #22572:
URL: https://github.com/apache/flink/pull/22572#issuecomment-1545222519

   I think removing all @Timeout annotations in the `flink-yarn-tests` makes sense. I found that annotation exists in the following files:
   _YarnConfigurationITCase.java
   YARNSessionFIFOSecuredITCase.java
   YARNHighAvailabilityITCase.java
   YARNSessionFIFOITCase.java_
   I'd like to remove all annotations in the java files, WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #22572: [FLINK-29618] Remove Timeout annotation in YARNSessionFIFOSecuredITCase

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22572:
URL: https://github.com/apache/flink/pull/22572#issuecomment-1545955981

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3e82df924333d6f676f20a50c068bb35fa7c3076",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3e82df924333d6f676f20a50c068bb35fa7c3076",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3e82df924333d6f676f20a50c068bb35fa7c3076 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] WencongLiu commented on pull request #22572: [FLINK-29618] Remove Timeout annotation in YARNSessionFIFOSecuredITCase

Posted by "WencongLiu (via GitHub)" <gi...@apache.org>.
WencongLiu commented on PR #22572:
URL: https://github.com/apache/flink/pull/22572#issuecomment-1545225187

   By the way, the CI system seems to meet a error and code push doesn't trigger to start the CI. Do you have a solution?🤔


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] XComp merged pull request #22572: [FLINK-29618][yarn-tests] Remove Timeout annotation in YARN-related integration tests

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #22572:
URL: https://github.com/apache/flink/pull/22572


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] WencongLiu commented on pull request #22572: [FLINK-29618] Remove Timeout annotation in YARNSessionFIFOSecuredITCase

Posted by "WencongLiu (via GitHub)" <gi...@apache.org>.
WencongLiu commented on PR #22572:
URL: https://github.com/apache/flink/pull/22572#issuecomment-1545314729

   Yes. No CI build is triggered anymore in the passed ten hours. I proposed it on https://issues.apache.org/jira/browse/FLINK-32066


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] WencongLiu commented on pull request #22572: [FLINK-29618] Remove Timeout annotation in YARNSessionFIFOSecuredITCase

Posted by "WencongLiu (via GitHub)" <gi...@apache.org>.
WencongLiu commented on PR #22572:
URL: https://github.com/apache/flink/pull/22572#issuecomment-1547494506

   Currently all timeout annotations have been removed in flink-yarn-tests module and CI has been approved. @XComp 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org