You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2025/03/04 13:03:46 UTC

Re: [PR] [SPARK-51349][SQL][TESTS] Change precedence of null and "null" in sorting in QueryTest [spark]

cloud-fan commented on code in PR #50108:
URL: https://github.com/apache/spark/pull/50108#discussion_r1979387686


##########
sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala:
##########
@@ -326,7 +326,13 @@ object QueryTest extends Assertions {
     // For binary arrays, we convert it to Seq to avoid of calling java.util.Arrays.equals for
     // equality test.
     val converted: Seq[Row] = answer.map(prepareRow)
-    if (!isSorted) converted.sortBy(_.toString()) else converted
+    // SPARK-51349: "null" and null had the same precedence in sorting
+    if (!isSorted) converted.sortBy( r =>
+      Row(r.toSeq.map {
+        case null => (0, null)

Review Comment:
   we need to do it recursively for nested Row as well, so I'd suggest we do this in the function `prepareRow`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org