You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/05 15:27:44 UTC

[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6348: Improving code related to the Agent properties

GutoVeronezi commented on code in PR #6348:
URL: https://github.com/apache/cloudstack/pull/6348#discussion_r1014649337


##########
utils/src/main/java/com/cloud/utils/net/NetUtils.java:
##########
@@ -420,30 +422,49 @@ public static String[] getNicParams(final String nicName) {
         }
     }
 
-    public static String[] getNetworkParams(final NetworkInterface nic) {
+    public static String[] getNetworkParams(NetworkInterface nic) {
+        s_logger.debug(String.format("Retrieving network params of NIC [%s].", nic));
+
+        s_logger.trace(String.format("Retrieving all NIC [%s] addresses.", nic));

Review Comment:
   Actually the first log refers to whole process and the second to the step being executed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org