You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/06/26 04:40:38 UTC
[GitHub] [dolphinscheduler] kyoty commented on pull request #5698: Revert "Fix the bug Edit User Info will always shows failed."
kyoty commented on pull request #5698:
URL: https://github.com/apache/dolphinscheduler/pull/5698#issuecomment-868946844
@chengshiwen Sorry for the trouble bring to you, my modification is based on 2 known issues:
1. When we open the user information page, the enable/disable status of current user would always shows empty
2
----so I add this:
```javascript
this.state = this.item.state
```
2. If the user has not configured a tenant yet, if he just want to modify his personal information, It would always occurs an error, the main reason is shown as the note:
```javascript
// If the user has not configured a tenant yet, this.item.tenantId would be 0, the if check returns false
// so I try to add a new check like this: if (this.item.tenantId || this.item.tenantId === 0)
if (this.item.tenantId) {
this.tenantId = this.item.tenantId
}
```
It's my fault that I did not explain clearly the reason for my modification in pr #5627
when I submit the pr, I've verified all the scenarios I know. I'm not sure what's the new bug you said ? If a bug is introduced, I am verty sorry, hoping for your reply. 😛
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org