[jira] [Commented] (AIRFLOW-3438) BigQueryOperator should default udf_config to None instead of false.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707721#comment-16707721 ] 

ASF GitHub Bot commented on AIRFLOW-3438:
-----------------------------------------

kaxil opened a new pull request #4274: [AIRFLOW-3438] Fix default value of udf_config in BQOperator
URL: https://github.com/apache/incubator-airflow/pull/4274
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. 
     - https://issues.apache.org/jira/browse/AIRFLOW-3438
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> BigQueryOperator should default udf_config to None instead of false.
> --------------------------------------------------------------------
>
>                 Key: AIRFLOW-3438
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3438
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>            Reporter: Luka Draksler
>            Priority: Major
>              Labels: easyfix
>             Fix For: 1.10.2
>
>
> BigQueryOperator currently sets default value of udf_config to False. This no longer works due to [https://github.com/apache/incubator-airflow/pull/3733] validating the type of that parameter as either None or list. Default value needs to be changed to None.
> The line in question added in the commit referenced above
> {code:java}
> (udf_config, 'userDefinedFunctionResources', None, list),
> {code}
>  
>  
> Note, other users of the hook may potentially encounter the same issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)