You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tez.apache.org by GitBox <gi...@apache.org> on 2022/10/26 00:56:26 UTC

[GitHub] [tez] ganeshashree commented on a diff in pull request #243: TEZ-4450: Shuffle data fetch fails when shuffle data is transferred via CompositeRoutedDataMovementEvent

ganeshashree commented on code in PR #243:
URL: https://github.com/apache/tez/pull/243#discussion_r1005110196


##########
tez-runtime-library/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker:
##########
@@ -0,0 +1,13 @@
+#   Licensed under the Apache License, Version 2.0 (the "License");

Review Comment:
   @abstractdog Both options work, the difference is just the extra file versus extra dependency. As per [this doc](https://javadoc.io/static/org.mockito/mockito-core/4.8.1/org/mockito/Mockito.html#39), `mockito-inline` artifact likely to be discontinued once mocking of final classes and methods gets integrated into the default mock maker. Please let me know if adding `mockito-inline` dependency looks better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org