You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Serge Sozonoff <se...@globalbeach.com> on 2003/01/23 23:14:05 UTC

[PATCH] Upgrade to DnsJava 1.3.2 + revision 2 of my original patch

Hi all,

This patch:

 Upgrades to the just released DnsJava 1.3.2 :-)
 Reverts some code back because the use of the static class dns was not a
good idea.
 Adds an autodiscover config parameter so that dns server autodiscover can
be turned on/off
 method findMXRecords() returns an unmodifiable Collection
 Added some more logging

I have done some basic testing and everything seems to work well.

Thanks to Noel and others for the help/input on this.

Sergei


Re: [PATCH] Upgrade to DnsJava 1.3.2 + revision 2 of my original patch

Posted by Harmeet Bedi <ha...@kodemuse.com>.
2 years back or so when I contributed my first patches, I think I was asked
or did both diff and full source.

I find full source is convenient and prefer that. Don't think there is any
need to have any hard and fast rules, if a contributor can submit source
good, otherwise good too.

Serge if you can submit source good, saves one step for the person adding it
in.

From: "Noel J. Bergman" <no...@devtech.com>
> Do you need help with patch?  Danny and I know how to use the linux
version.
> I presume that Serge can tell you how to use a Windows version.

I don't think it is such a big deal. If you or Danny are around and want to
add the patch go ahead or I'll do it over the weekend if it has not been
done.
The patch seems pretty straight forward. Noel, what sort of help did you
have in mind ? version of what ?

Harmeet
----- Original Message -----
From: "Noel J. Bergman" <no...@devtech.com>
To: "James Developers List" <ja...@jakarta.apache.org>
Sent: Thursday, January 23, 2003 11:38 PM
Subject: RE: [PATCH] Upgrade to DnsJava 1.3.2 + revision 2 of my original
patch


> > Serge, could you please post the modified DNSServer.java and
> > james-config.xml file.
>
> > It will be easier to apply the patch if you post these sources.
>
> See: http://james.apache.org/contribute.html
>
> Sergei followed the rules as we've asked.  I remember Danny sending me a
> message in response to my first contribution asking just the opposite: I
> should post a diff, not send the code.
>
> Do you need help with patch?  Danny and I know how to use the linux
version.
> I presume that Serge can tell you how to use a Windows version.
>
> --- Noel
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


RE: [PATCH] Upgrade to DnsJava 1.3.2 + revision 2 of my original patch

Posted by "Noel J. Bergman" <no...@devtech.com>.
> Serge, could you please post the modified DNSServer.java and
> james-config.xml file.

> It will be easier to apply the patch if you post these sources.

See: http://james.apache.org/contribute.html

Sergei followed the rules as we've asked.  I remember Danny sending me a
message in response to my first contribution asking just the opposite: I
should post a diff, not send the code.

Do you need help with patch?  Danny and I know how to use the linux version.
I presume that Serge can tell you how to use a Windows version.

	--- Noel


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [PATCH] Upgrade to DnsJava 1.3.2 + revision 2 of my original patch

Posted by Harmeet Bedi <ha...@kodemuse.com>.
Serge, could you please post the modified DNSServer.java and
james-config.xml file.

It will be easier to apply the patch if you post these sources.

thanks,
Harmeet


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


RE: [PATCH] Upgrade to DnsJava 1.3.2 + revision 2 of my original patch

Posted by "Noel J. Bergman" <no...@devtech.com>.
Sergei,

Thanks.  I have applied this to the CVS, and updated the changelog document.
Also added you to the "we are" page.  Those changes will appear next time we
re-publish the web site.

	--- Noel

-----Original Message-----
From: Serge Sozonoff [mailto:serge@globalbeach.com]
Sent: Thursday, January 23, 2003 17:14
To: James Developers List
Subject: [PATCH] Upgrade to DnsJava 1.3.2 + revision 2 of my original
patch


Hi all,

This patch:

 Upgrades to the just released DnsJava 1.3.2 :-)
 Reverts some code back because the use of the static class dns was not a
good idea.
 Adds an autodiscover config parameter so that dns server autodiscover can
be turned on/off
 method findMXRecords() returns an unmodifiable Collection
 Added some more logging

I have done some basic testing and everything seems to work well.

Thanks to Noel and others for the help/input on this.

Sergei



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>