You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by sutambe <gi...@git.apache.org> on 2017/09/13 17:40:36 UTC

[GitHub] kafka pull request #3849: Implement KIP-91 delivery.timeout.ms

GitHub user sutambe opened a pull request:

    https://github.com/apache/kafka/pull/3849

    Implement KIP-91 delivery.timeout.ms

    First shot at implementing kip-91 delivery.timeout.ms. Summary
    
    1. Added delivery.timeout.ms config. Default 120,000
    2. Changed retries to MAX_INT.
    3. batches may expire whether they are inflight or not. So muted is no longer used in RecordAccumulator.expiredBatches.
    4. In some rare situations batch.done may be called twice. Attempted transitions from failed to succeeded are logged. Successful to successful is an error (exception as before). Other transitions (failed-->aborted, aborted-->failed) are ignored.
    5. The old test from RecordAccumulatorTest is removed. It has three additional tests. testExpiredBatchSingle, testExpiredBatchesSize, testExpiredBatchesRetry. All of them test that expiry is independent of muted.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sutambe/kafka kip91

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3849.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3849
    
----
commit 9d9ff99e1e41f92e75ece0da81ad75948bd33132
Author: Sumant Tambe <su...@linkedin.com>
Date:   2017-09-13T16:56:03Z

    implement delivery.timeout.ms

----


---