You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2013/07/30 05:06:17 UTC
[jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
* module jclouds-cli-project -> project
* removing unnecessary duplicate versions and group IDs
Follow-on from bb56570
Tested as follows:
* `mvn clean package` succeeds
* `mvn release:prepare` seems to ["do the right thing"](http://pastie.org/private/uu7wabhqfpdzzplzibgsza)
**Please verify by running `mvn release:prepare` locally**
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds-cli update-poms
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-cli/pull/14
-- Commit Summary --
* JCLOUDS-104: Cleaning up CLI POMs
-- File Changes --
M assembly/pom.xml (6)
M branding/pom.xml (6)
M pom.xml (8)
R project/pom.xml (13)
M runner/pom.xml (6)
-- Patch Links --
https://github.com/jclouds/jclouds-cli/pull/14.patch
https://github.com/jclouds/jclouds-cli/pull/14.diff
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-cli-pull-requests #15](https://jclouds.ci.cloudbees.com/job/jclouds-cli-pull-requests/15/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29050855
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by Zack Shoylev <no...@github.com>.
Alright, excellent. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29050025
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by Zack Shoylev <no...@github.com>.
I would like to keep this consistent though. In other words, if we can also remove the "extra" version tag in other projects as well (and keep it survivable :) ), we should... otherwise keep the extra version. Thoughts?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29042569
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by Andrew Phillips <no...@github.com>.
Squashed. Waiting for a final DEV@cloud build before merging.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29050727
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by Andrew Phillips <no...@github.com>.
@iocanel: Does this look reasonable to you..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-21834335
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by Zack Shoylev <no...@github.com>.
> What would that do beyond allow you to have different versions for each subproject, which I assume we're not planning?
I thought support for different versions was needed when building for new releases? I hope I am wrong.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29012034
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-cli-pull-requests #14](https://jclouds.ci.cloudbees.com/job/jclouds-cli-pull-requests/14/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29049743
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by Andrew Phillips <no...@github.com>.
PS: I'd highly recommend running `mvn release:prepare`. It's comforting to see it working.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-21768194
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by Andrew Phillips <no...@github.com>.
> Interesting, I was under the impression that the version tag is needed within each project?
What would that do beyond allow you to have different versions for each subproject, which I assume we're not planning?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-21768132
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-cli.git;h=8a43a4d)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29051763
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-cli-pull-requests #12](https://jclouds.ci.cloudbees.com/job/jclouds-cli-pull-requests/12/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29017602
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by Andrew Phillips <no...@github.com>.
> I thought support for different versions was needed when building for new releases? I hope I am wrong.
No, that's correct. Well spotted - it looks like we need a `<version>...` tag in the [project POM](https://github.com/jclouds/jclouds-cli/blob/b29f8651e5ddf45ab5291245e07083d136edd246/project/pom.xml#L30) to allow the jclouds-cli version to be a SNAPSHOT while the jclouds-project version is already a release version.
A bit like the [Labs POM](https://github.com/jclouds/jclouds-labs/blob/master/pom.xml#L29)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29014888
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by Zack Shoylev <no...@github.com>.
Interesting, I was under the impression that the version tag is needed within each project?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-21768053
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by Andrew Phillips <no...@github.com>.
@zack-shoylev: Reviewing the [output from release:prepare](http://pastie.org/private/uu7wabhqfpdzzplzibgsza), it looks like the additional `<version>..` property may actually be unnecessary:
```
Dependency 'org.apache.jclouds:jclouds-project' is a snapshot (1.7.0-SNAPSHOT)
: Which release version should it be set to? 1.7.0: : 1.6.1-incubating
...
```
But, because the parent version isn't set to a non-snapshot _before_ the release, it then continues to ask for the version for all the _other_ jclouds core deps (line 38 onwards).
It's that annoying thing that the explicit jclouds-project vs. jclouds-cli version avoids, although for the relatively small number of deps here it's probably still survivable.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29023734
Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)
Posted by Andrew Phillips <no...@github.com>.
> I would like to keep this consistent though
Agree. So let's leave it in for now. But it's good to know the opportunity exists, and what the potential costs are ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29049258