You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2019/08/27 18:39:29 UTC

[tinkerpop] 02/03: Minor code formatting CTR

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git

commit 447d120c1e2165f2c345207335e8850801a28118
Author: Stephen Mallette <sp...@genoprime.com>
AuthorDate: Tue Aug 27 13:45:25 2019 -0400

    Minor code formatting CTR
---
 CHANGELOG.asciidoc                                 |  2 +-
 .../traversal/dsl/GremlinDslProcessorTest.java     | 22 +++++++++++-----------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index b08d99c..4197095 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -23,7 +23,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
 [[release-3-4-4]]
 === TinkerPop 3.4.4 (Release Date: NOT OFFICIALLY RELEASED YET)
 
-* Support DSL with remote connection.
+* Provided support for DSLs by way of remote connections through `AnonymousTraversalSource`.
 
 [[release-3-4-3]]
 === TinkerPop 3.4.3 (Release Date: August 5, 2019)
diff --git a/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessorTest.java b/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessorTest.java
index b13b5e0..23876c6 100644
--- a/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessorTest.java
+++ b/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessorTest.java
@@ -42,7 +42,7 @@ public class GremlinDslProcessorTest {
 
     @Test
     public void shouldCompileToDefaultPackage() {
-        Compilation compilation = javac()
+        final Compilation compilation = javac()
                 .withProcessors(new GremlinDslProcessor())
                 .compile(JavaFileObjects.forResource(GremlinDsl.class.getResource("SocialTraversalDsl.java")));
         assertThat(compilation).succeededWithoutWarnings();
@@ -50,7 +50,7 @@ public class GremlinDslProcessorTest {
 
     @Test
     public void shouldCompileAndMovePackage() {
-        Compilation compilation = javac()
+        final Compilation compilation = javac()
                 .withProcessors(new GremlinDslProcessor())
                 .compile(JavaFileObjects.forResource(GremlinDsl.class.getResource("SocialMoveTraversalDsl.java")));
         assertThat(compilation).succeededWithoutWarnings();
@@ -60,7 +60,7 @@ public class GremlinDslProcessorTest {
 
     @Test
     public void shouldCompileTraversalAndTraversalSourceToDefaultPackage() {
-        Compilation compilation = javac()
+        final Compilation compilation = javac()
                 .withProcessors(new GremlinDslProcessor())
                 .compile(JavaFileObjects.forResource(GremlinDsl.class.getResource("SocialPackageTraversalDsl.java")));
         assertThat(compilation).succeededWithoutWarnings();
@@ -68,7 +68,7 @@ public class GremlinDslProcessorTest {
 
     @Test
     public void shouldCompileWithNoDefaultMethods() {
-        Compilation compilation = javac()
+        final Compilation compilation = javac()
                 .withProcessors(new GremlinDslProcessor())
                 .compile(JavaFileObjects.forResource(GremlinDsl.class.getResource("SocialNoDefaultMethodsTraversalDsl.java")));
         assertThat(compilation).succeededWithoutWarnings();
@@ -76,14 +76,14 @@ public class GremlinDslProcessorTest {
 
     @Test
     public void shouldCompileRemoteDslTraversal() {
-        Compilation compilation = javac()
+        final Compilation compilation = javac()
                 .withProcessors(new GremlinDslProcessor())
                 .compile(JavaFileObjects.forResource(GremlinDsl.class.getResource("SocialTraversalDsl.java")),
                         JavaFileObjects.forResource(GremlinDsl.class.getResource("RemoteDslTraversal.java")));
 
         try {
-            ClassLoader cl = new JavaFileObjectClassLoader(compilation.generatedFiles());
-            Class cls = cl.loadClass("org.apache.tinkerpop.gremlin.process.traversal.dsl.RemoteDslTraversal");
+            final ClassLoader cl = new JavaFileObjectClassLoader(compilation.generatedFiles());
+            final Class cls = cl.loadClass("org.apache.tinkerpop.gremlin.process.traversal.dsl.RemoteDslTraversal");
             cls.getConstructor().newInstance();
         } catch (Exception e) {
             throw new RuntimeException(e);
@@ -110,11 +110,11 @@ public class GremlinDslProcessorTest {
         }
 
         private byte[] loadClassData(String name) throws IOException {
-            ByteArrayOutputStream out = new ByteArrayOutputStream();
-            String classFilename = name.replaceAll("\\.", "/") + ".class";
-            InputStream in = classFileMap.get(classFilename).openInputStream();
+            final ByteArrayOutputStream out = new ByteArrayOutputStream();
+            final String classFilename = name.replaceAll("\\.", "/") + ".class";
+            final InputStream in = classFileMap.get(classFilename).openInputStream();
             try {
-                byte[] buf = new byte[1024];
+                final byte[] buf = new byte[1024];
                 int len = in.read(buf);
                 while (len != -1) {
                     out.write(buf, 0, len);