You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Maxime Chassagneux <ma...@gmail.com> on 2017/02/17 08:41:23 UTC
Preserve encoding file for JUnit test
Hi,
Actualy the build fail because of my new JUnit for JMS.
I have a problem to preserve encoding file.
Someone can help me ?
Re: Preserve encoding file for JUnit test
Posted by Philippe Mouawad <ph...@gmail.com>.
Thanks for tip
On Friday, February 17, 2017, Milamber <mi...@apache.org> wrote:
>
>
> On 17/02/2017 12:56, Philippe Mouawad wrote:
>
>> - When you add a new Java class, ensure you set SVN property: svn:eol
>> =
>> native and add a new line at end of file. For XML it's usually LF =>
>> DONE
>>
>
> You can adjust your svn client auto-props to get the correct svn:mime-type
> properties on additions
> You can do this with the editing of ~/.subversion/config file, and add the
> lines from this files
>
> http://www.apache.org/dev/svn-eol-style.txt
>
>
>
>
--
Cordialement.
Philippe Mouawad.
Re: Preserve encoding file for JUnit test
Posted by Milamber <mi...@apache.org>.
On 17/02/2017 12:56, Philippe Mouawad wrote:
> - When you add a new Java class, ensure you set SVN property: svn:eol =
> native and add a new line at end of file. For XML it's usually LF => DONE
You can adjust your svn client auto-props to get the correct
svn:mime-type properties on additions
You can do this with the editing of ~/.subversion/config file, and add
the lines from this files
http://www.apache.org/dev/svn-eol-style.txt
Re: Preserve encoding file for JUnit test
Posted by Philippe Mouawad <ph...@gmail.com>.
On Friday, February 17, 2017, Maxime Chassagneux <
maxime.chassagneux@gmail.com> wrote:
> Hi Philippe,
>
> Thanks for all your remarks, I have to be more careful.
> Again sorry for this, I'm not used to SVN.
My notes were not a reproach :)
Just to inform you about practices on project thay you cannot guess except
for javadocs :)
>
> Regards
>
> 2017-02-17 13:56 GMT+01:00 Philippe Mouawad <philippe.mouawad@gmail.com
> <javascript:;>>:
>
> > Hello Maxime,
> > I've fixed the problem.
> >
> > Regarding your first commits on project, few notes:
> >
> > - For any bug or enhancement, for now we should always create a
> > bugzilla. PR only should in my opinion only be used for Technical
> > improvements of code (Sonar fixes) or translations for example =>
> DONE
> > - Once you have commited, ensure you put as comment the commit message
> > in the bugzilla. This allows better understanding of fixes and better
> > tracability
> > - Code should have javadocs for all public methods and for classes,
> and
> > avoid introducing new javadoc errors. => TODO on last commit
> > - When you add a new Java class, ensure you set SVN property: svn:eol
> =
> > native and add a new line at end of file. For XML it's usually LF =>
> > DONE
> >
> > Thanks
> >
> > Regards
> >
> > On Fri, Feb 17, 2017 at 9:41 AM, Maxime Chassagneux <
> > maxime.chassagneux@gmail.com <javascript:;>> wrote:
> >
> > > Hi,
> > >
> > > Actualy the build fail because of my new JUnit for JMS.
> > > I have a problem to preserve encoding file.
> > > Someone can help me ?
> > >
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
>
--
Cordialement.
Philippe Mouawad.
Re: Preserve encoding file for JUnit test
Posted by Maxime Chassagneux <ma...@gmail.com>.
Hi Philippe,
Thanks for all your remarks, I have to be more careful.
Again sorry for this, I'm not used to SVN.
Regards
2017-02-17 13:56 GMT+01:00 Philippe Mouawad <ph...@gmail.com>:
> Hello Maxime,
> I've fixed the problem.
>
> Regarding your first commits on project, few notes:
>
> - For any bug or enhancement, for now we should always create a
> bugzilla. PR only should in my opinion only be used for Technical
> improvements of code (Sonar fixes) or translations for example => DONE
> - Once you have commited, ensure you put as comment the commit message
> in the bugzilla. This allows better understanding of fixes and better
> tracability
> - Code should have javadocs for all public methods and for classes, and
> avoid introducing new javadoc errors. => TODO on last commit
> - When you add a new Java class, ensure you set SVN property: svn:eol =
> native and add a new line at end of file. For XML it's usually LF =>
> DONE
>
> Thanks
>
> Regards
>
> On Fri, Feb 17, 2017 at 9:41 AM, Maxime Chassagneux <
> maxime.chassagneux@gmail.com> wrote:
>
> > Hi,
> >
> > Actualy the build fail because of my new JUnit for JMS.
> > I have a problem to preserve encoding file.
> > Someone can help me ?
> >
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
Re: Preserve encoding file for JUnit test
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello Maxime,
I've fixed the problem.
Regarding your first commits on project, few notes:
- For any bug or enhancement, for now we should always create a
bugzilla. PR only should in my opinion only be used for Technical
improvements of code (Sonar fixes) or translations for example => DONE
- Once you have commited, ensure you put as comment the commit message
in the bugzilla. This allows better understanding of fixes and better
tracability
- Code should have javadocs for all public methods and for classes, and
avoid introducing new javadoc errors. => TODO on last commit
- When you add a new Java class, ensure you set SVN property: svn:eol =
native and add a new line at end of file. For XML it's usually LF => DONE
Thanks
Regards
On Fri, Feb 17, 2017 at 9:41 AM, Maxime Chassagneux <
maxime.chassagneux@gmail.com> wrote:
> Hi,
>
> Actualy the build fail because of my new JUnit for JMS.
> I have a problem to preserve encoding file.
> Someone can help me ?
>
--
Cordialement.
Philippe Mouawad.