[jira] [Commented] (MWRAPPER-65) MavenWrapperDownloader.java ignores the MVNW_REPOURL env

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MWRAPPER-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538135#comment-17538135 ] 

ASF GitHub Bot commented on MWRAPPER-65:
----------------------------------------

jorsol opened a new pull request, #42:
URL: https://github.com/apache/maven-wrapper/pull/42

   This simplifies the MavenWrapperDownloader.java script by removing many of the redundant code that was already done on the shell script, fixing the problem when MVNW_REPOURL env variable was used but not read by the MavenWrapperDownloader.java.
   
   Also wrap the calls when MVNW_VERBOSE is used to a log function in the shell script.
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [X] Each commit in the pull request should have a meaningful subject line and body.
    - [X] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> MavenWrapperDownloader.java ignores the MVNW_REPOURL env
> --------------------------------------------------------
>
>                 Key: MWRAPPER-65
>                 URL: https://issues.apache.org/jira/browse/MWRAPPER-65
>             Project: Maven Wrapper
>          Issue Type: Bug
>          Components: Maven Wrapper Scripts
>    Affects Versions: 3.1.0, 3.1.1
>            Reporter: Jorge Solórzano
>            Priority: Normal
>
> Problem:
> MavenWrapperDownloader.java does not read the environment variable MVNW_REPOURL, so in the case the script has to fallback to the java download version instead of wget/curl, then the behavior will be different and actually might fail as the repository will not be the same.
> Proposal:
> Instead of making MavenWrapperDownloader.java more complex I actually propose the opposite, the MavenWrapperDownloader.java can be simplified by removing code that's already done by the script such as the reading of the property file, the DEFAULT_DOWNLOAD_URL... basically make the MavenWrapperDownloader.java to behave as curl and wget by passing "$wrapperJarPath" "$wrapperUrl" parameters without a lot of the current logic that's already done on the script.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)