[GitHub] [superset] rusackas commented on a change in pull request #14478: fix: fix adhocpopovers tab animate.

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #14478:
URL: https://github.com/apache/superset/pull/14478#discussion_r630596409



##########
File path: superset-frontend/spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx
##########
@@ -128,10 +128,11 @@ describe('DashboardBuilder', () => {
     expect(parentSize.find(Tabs.TabPane)).toHaveLength(2);
   });
 
-  it('should set animated=true on Tabs for perf', () => {
+  it('should have default animated=true on Tabs for perf', () => {
     const wrapper = setup({ dashboardLayout: undoableDashboardLayoutWithTabs });
     const tabProps = wrapper.find(ParentSize).find(Tabs).props();
-    expect(tabProps.animated).toEqual({ inkBar: true, tabPane: false });
+    console.log('tabProps', tabProps)

Review comment:
       Probably want to remove this console log. There CI linter is failing on the PR - this is likely one of the issues that needs addressing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org