You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mehrdad Nurolahzade <me...@nurolahzade.com> on 2017/01/23 17:00:24 UTC
Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate
limiter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55471/
-----------------------------------------------------------
(Updated Jan. 23, 2017, 9 a.m.)
Review request for Aurora, Joshua Cohen and Stephan Erb.
Changes
-------
Changed stat from time tracker to counter (as per comments above)
Summary (updated)
-----------------
AURORA-1876 Expose stats on scheduler rate limiter
Bugs: AURORA-1876
https://issues.apache.org/jira/browse/AURORA-1876
Repository: aurora
Description (updated)
-------
This patch exposes stats on `rateLimiter.acquire()` blocking events in `TaskGroups`. Hence, providing visibility into whether scheduling rate is above/below `MAX_SCHEDULE_ATTEMPTS_PER_SEC`.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 2d548b0adc9219080aa8e0e8b329f57edda01c13
src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 566e0d9ee8976a5eadd3088d34280fcfb0de3df0
Diff: https://reviews.apache.org/r/55471/diff/
Testing (updated)
-------
```
$ curl localhost:8081/vars | grep schedule_attempts_blocks
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 27976 0 27976 0 0 2836k 0 --:--:-- --:--:-- --:--:-- 3415k
schedule_attempts_blocks 0
```
Thanks,
Mehrdad Nurolahzade
Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate
limiter
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55471/#review162653
-----------------------------------------------------------
Master (dc6f27e) is red with this patch.
./build-support/jenkins/build.sh
-----------
* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for org/apache/aurora/scheduler/storage/db/views/DbImage
Test coverage missing for org/apache/aurora/scheduler/http/Mname
Test coverage missing for org/apache/aurora/scheduler/http/Services
Test coverage missing for org/apache/aurora/scheduler/http/QuitCallback
Test coverage missing for org/apache/aurora/scheduler/http/Cron
Test coverage missing for org/apache/aurora/scheduler/app/VolumeParser
Test coverage missing for org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader$Schema
Test coverage missing for org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader
Test coverage missing for org/apache/aurora/scheduler/pruning/TaskHistoryPruner$1
Test coverage missing for org/apache/aurora/scheduler/stats/AsyncStatsModule$OfferAdapter
Test coverage missing for org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroUtils
Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$3
Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$2
Test coverage missing for org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser
Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule
Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule$1
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$OpStats
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$1
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogEntry
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogPosition
Test coverage missing for org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule
Test coverage missing for org/apache/aurora/scheduler/reconciliation/KillRetry$KillAttempt
Test coverage missing for org/apache/aurora/scheduler/preemptor/Preemptor$PreemptorImpl
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverDisconnected
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverRegistered
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 5 mins 55.074 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 23, 2017, 5 p.m., Mehrdad Nurolahzade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55471/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 5 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Stephan Erb.
>
>
> Bugs: AURORA-1876
> https://issues.apache.org/jira/browse/AURORA-1876
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch exposes stats on `rateLimiter.acquire()` blocking events in `TaskGroups`. Hence, providing visibility into whether scheduling rate is above/below `MAX_SCHEDULE_ATTEMPTS_PER_SEC`.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 2d548b0adc9219080aa8e0e8b329f57edda01c13
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 566e0d9ee8976a5eadd3088d34280fcfb0de3df0
>
> Diff: https://reviews.apache.org/r/55471/diff/
>
>
> Testing
> -------
>
> ```
> $ curl localhost:8081/vars | grep schedule_attempts_blocks
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 100 27976 0 27976 0 0 2836k 0 --:--:-- --:--:-- --:--:-- 3415k
> schedule_attempts_blocks 0
> ```
>
>
> Thanks,
>
> Mehrdad Nurolahzade
>
>
Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate
limiter
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55471/#review162657
-----------------------------------------------------------
@ReviewBot retry
- Stephan Erb
On Jan. 23, 2017, 6 p.m., Mehrdad Nurolahzade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55471/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 6 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Stephan Erb.
>
>
> Bugs: AURORA-1876
> https://issues.apache.org/jira/browse/AURORA-1876
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch exposes stats on `rateLimiter.acquire()` blocking events in `TaskGroups`. Hence, providing visibility into whether scheduling rate is above/below `MAX_SCHEDULE_ATTEMPTS_PER_SEC`.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 2d548b0adc9219080aa8e0e8b329f57edda01c13
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 566e0d9ee8976a5eadd3088d34280fcfb0de3df0
>
> Diff: https://reviews.apache.org/r/55471/diff/
>
>
> Testing
> -------
>
> ```
> $ curl localhost:8081/vars | grep schedule_attempts_blocks
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 100 27976 0 27976 0 0 2836k 0 --:--:-- --:--:-- --:--:-- 3415k
> schedule_attempts_blocks 0
> ```
>
>
> Thanks,
>
> Mehrdad Nurolahzade
>
>
Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate
limiter
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55471/#review162695
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Jan. 23, 2017, 5 p.m., Mehrdad Nurolahzade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55471/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 5 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Stephan Erb.
>
>
> Bugs: AURORA-1876
> https://issues.apache.org/jira/browse/AURORA-1876
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch exposes stats on `rateLimiter.acquire()` blocking events in `TaskGroups`. Hence, providing visibility into whether scheduling rate is above/below `MAX_SCHEDULE_ATTEMPTS_PER_SEC`.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 2d548b0adc9219080aa8e0e8b329f57edda01c13
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 566e0d9ee8976a5eadd3088d34280fcfb0de3df0
>
> Diff: https://reviews.apache.org/r/55471/diff/
>
>
> Testing
> -------
>
> ```
> $ curl localhost:8081/vars | grep schedule_attempts_blocks
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 100 27976 0 27976 0 0 2836k 0 --:--:-- --:--:-- --:--:-- 3415k
> schedule_attempts_blocks 0
> ```
>
>
> Thanks,
>
> Mehrdad Nurolahzade
>
>
Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate
limiter
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55471/#review162686
-----------------------------------------------------------
Ship it!
The counter LGTM.
Thanks for updating this stat.
- Zameer Manji
On Jan. 23, 2017, 9 a.m., Mehrdad Nurolahzade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55471/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 9 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Stephan Erb.
>
>
> Bugs: AURORA-1876
> https://issues.apache.org/jira/browse/AURORA-1876
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch exposes stats on `rateLimiter.acquire()` blocking events in `TaskGroups`. Hence, providing visibility into whether scheduling rate is above/below `MAX_SCHEDULE_ATTEMPTS_PER_SEC`.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 2d548b0adc9219080aa8e0e8b329f57edda01c13
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 566e0d9ee8976a5eadd3088d34280fcfb0de3df0
>
> Diff: https://reviews.apache.org/r/55471/diff/
>
>
> Testing
> -------
>
> ```
> $ curl localhost:8081/vars | grep schedule_attempts_blocks
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 100 27976 0 27976 0 0 2836k 0 --:--:-- --:--:-- --:--:-- 3415k
> schedule_attempts_blocks 0
> ```
>
>
> Thanks,
>
> Mehrdad Nurolahzade
>
>
Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate
limiter
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55471/#review162663
-----------------------------------------------------------
Master (dc6f27e) is red with this patch.
./build-support/jenkins/build.sh
Test coverage missing for org/apache/aurora/scheduler/reconciliation/TaskTimeout$TimedOutTaskHandler
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob$CronBatchWorker
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob$Config
Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups$TaskGroupBatchWorker
Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups$1
Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups
Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$2
Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$1
Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$3
Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$2
Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$1
Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats
Test coverage missing for org/apache/aurora/scheduler/thrift/AuditMessages
Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor
Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$1
Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$2
Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$3
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptorModule$PreemptorService
Test coverage missing for org/apache/aurora/scheduler/events/WebhookModule
Test coverage missing for org/apache/aurora/scheduler/events/Webhook
Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo
Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
Test coverage missing for org/apache/aurora/scheduler/TaskVars
Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 5 mins 30.22 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 23, 2017, 5 p.m., Mehrdad Nurolahzade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55471/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 5 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Stephan Erb.
>
>
> Bugs: AURORA-1876
> https://issues.apache.org/jira/browse/AURORA-1876
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch exposes stats on `rateLimiter.acquire()` blocking events in `TaskGroups`. Hence, providing visibility into whether scheduling rate is above/below `MAX_SCHEDULE_ATTEMPTS_PER_SEC`.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 2d548b0adc9219080aa8e0e8b329f57edda01c13
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 566e0d9ee8976a5eadd3088d34280fcfb0de3df0
>
> Diff: https://reviews.apache.org/r/55471/diff/
>
>
> Testing
> -------
>
> ```
> $ curl localhost:8081/vars | grep schedule_attempts_blocks
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 100 27976 0 27976 0 0 2836k 0 --:--:-- --:--:-- --:--:-- 3415k
> schedule_attempts_blocks 0
> ```
>
>
> Thanks,
>
> Mehrdad Nurolahzade
>
>
Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate
limiter
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55471/#review162656
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On Jan. 23, 2017, 6 p.m., Mehrdad Nurolahzade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55471/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 6 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Stephan Erb.
>
>
> Bugs: AURORA-1876
> https://issues.apache.org/jira/browse/AURORA-1876
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch exposes stats on `rateLimiter.acquire()` blocking events in `TaskGroups`. Hence, providing visibility into whether scheduling rate is above/below `MAX_SCHEDULE_ATTEMPTS_PER_SEC`.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 2d548b0adc9219080aa8e0e8b329f57edda01c13
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 566e0d9ee8976a5eadd3088d34280fcfb0de3df0
>
> Diff: https://reviews.apache.org/r/55471/diff/
>
>
> Testing
> -------
>
> ```
> $ curl localhost:8081/vars | grep schedule_attempts_blocks
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 100 27976 0 27976 0 0 2836k 0 --:--:-- --:--:-- --:--:-- 3415k
> schedule_attempts_blocks 0
> ```
>
>
> Thanks,
>
> Mehrdad Nurolahzade
>
>