You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/01/24 19:15:32 UTC
[GitHub] [ozone] fapifta opened a new pull request #3016: HDDS-6220. EC: Introduce a gRPC client implementation for EC with really async WriteChunk and PutBlock.
fapifta opened a new pull request #3016:
URL: https://github.com/apache/ozone/pull/3016
## What changes were proposed in this pull request?
In order to enable real async WriteChunk and PutBlock, a change in the original XCeiverClientGrpc is done to extract the decision to a method whether we should wait until the result arrives or we should not. With that we can override this decision in the EC related implementation with yielding to do not wait ever for a response, just return the client reply with the future.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6220
## How was this patch tested?
Current JUnit an integration tests should work as they did with the new client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on a change in pull request #3016: HDDS-6220. EC: Introduce a gRPC client implementation for EC with really async WriteChunk and PutBlock.
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on a change in pull request #3016:
URL: https://github.com/apache/ozone/pull/3016#discussion_r791287149
##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -470,6 +470,11 @@ public XceiverClientReply sendCommandAsync(
}
}
Review comment:
A minor comment: Please provide some documentation something like "sendCommandAsync uses this API to decide whether command to work in async mode or in sync mode. In XceiverClientGrpc, read requests are async and write requests are sync. So, this method should return true for write commands and false for read."
So, in overridden EC specific API can document about both write and read should be in sync.
##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -470,6 +470,11 @@ public XceiverClientReply sendCommandAsync(
}
}
Review comment:
Otherwise mostly patch looks straightforward and looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on a change in pull request #3016: HDDS-6220. EC: Introduce a gRPC client implementation for EC with really async WriteChunk and PutBlock.
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on a change in pull request #3016:
URL: https://github.com/apache/ozone/pull/3016#discussion_r791287149
##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -470,6 +470,11 @@ public XceiverClientReply sendCommandAsync(
}
}
Review comment:
A minor comment: Please provide some documentation something like "sendCommandAsync uses this API to decide whether command to work in async mode or in sync mode. In XceiverClientGrpc, read requests are async and write requests are sync. So, this method should return true for write commands and false for read."
So, in overridden EC specific API can document about both write and read should be in sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on a change in pull request #3016: HDDS-6220. EC: Introduce a gRPC client implementation for EC with really async WriteChunk and PutBlock.
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on a change in pull request #3016:
URL: https://github.com/apache/ozone/pull/3016#discussion_r791287603
##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -470,6 +470,11 @@ public XceiverClientReply sendCommandAsync(
}
}
Review comment:
Otherwise mostly patch looks straightforward and looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on a change in pull request #3016: HDDS-6220. EC: Introduce a gRPC client implementation for EC with really async WriteChunk and PutBlock.
Posted by GitBox <gi...@apache.org>.
fapifta commented on a change in pull request #3016:
URL: https://github.com/apache/ozone/pull/3016#discussion_r791414388
##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -470,6 +470,11 @@ public XceiverClientReply sendCommandAsync(
}
}
Review comment:
I have added API doc for both implementation of this method. Thank you for noting this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta merged pull request #3016: HDDS-6220. EC: Introduce a gRPC client implementation for EC with really async WriteChunk and PutBlock.
Posted by GitBox <gi...@apache.org>.
fapifta merged pull request #3016:
URL: https://github.com/apache/ozone/pull/3016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on a change in pull request #3016: HDDS-6220. EC: Introduce a gRPC client implementation for EC with really async WriteChunk and PutBlock.
Posted by GitBox <gi...@apache.org>.
fapifta commented on a change in pull request #3016:
URL: https://github.com/apache/ozone/pull/3016#discussion_r791414388
##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -470,6 +470,11 @@ public XceiverClientReply sendCommandAsync(
}
}
Review comment:
I have added API doc for both implementation of this method. Thank you for noting this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org