You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/27 07:57:14 UTC
[GitHub] [flink] zhuzhurk opened a new pull request #11230: [FLINK-16300]
Rework SchedulerTestUtils with testing classes to replace mockito usages
zhuzhurk opened a new pull request #11230: [FLINK-16300] Rework SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230
## What is the purpose of the change
Mockito is used in SchedulerTestUtils to mock ExecutionVertex and Execution for testing. It fails to mock every getter so that other tests use it may encounter NPE issues, e.g. ExecutionVertex#getID().
Mockito is also discouraged to be used in Flink tests. So I'd propose to rework the utils with testing classes.
## Brief change log
Reworked the SchedulerTestUtils methods with testing classes.
## Verifying this change
This change is already covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11230: [FLINK-16300]
Rework SchedulerTestUtils with testing classes to replace mockito usages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11230: [FLINK-16300] Rework SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230#issuecomment-591836588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150791462",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
}, {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5673",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
}, {
"hash" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151754559",
"triggerID" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"triggerType" : "PUSH"
}, {
"hash" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5925",
"triggerID" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8c5f1c4014828755123a8680f78dc3fec3a6bf4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150791462) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5673)
* 24a1eb4c4f93bcad751caf10a0b5f52de95f621b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151754559) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5925)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11230: [FLINK-16300] Rework
SchedulerTestUtils with testing classes to replace mockito usages
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11230: [FLINK-16300] Rework SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230#issuecomment-591834431
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d8c5f1c4014828755123a8680f78dc3fec3a6bf4 (Thu Feb 27 07:59:22 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11230: [FLINK-16300]
Rework SchedulerTestUtils with testing classes to replace mockito usages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11230: [FLINK-16300] Rework SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230#issuecomment-591836588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150791462",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
}, {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5673",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
}, {
"hash" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151754559",
"triggerID" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"triggerType" : "PUSH"
}, {
"hash" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5925",
"triggerID" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 24a1eb4c4f93bcad751caf10a0b5f52de95f621b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151754559) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5925)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk merged pull request #11230: [FLINK-16300] Rework
SchedulerTestUtils with testing classes to replace mockito usages
Posted by GitBox <gi...@apache.org>.
zhuzhurk merged pull request #11230: [FLINK-16300] Rework SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11230: [FLINK-16300]
Rework SchedulerTestUtils with testing classes to replace mockito usages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11230: [FLINK-16300] Rework SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230#issuecomment-591836588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150791462",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
}, {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5673",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8c5f1c4014828755123a8680f78dc3fec3a6bf4 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150791462) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5673)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11230: [FLINK-16300] Rework
SchedulerTestUtils with testing classes to replace mockito usages
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11230: [FLINK-16300] Rework SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230#issuecomment-591836588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8c5f1c4014828755123a8680f78dc3fec3a6bf4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11230: [FLINK-16300]
Rework SchedulerTestUtils with testing classes to replace mockito usages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11230: [FLINK-16300] Rework SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230#issuecomment-591836588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150791462",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
}, {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5673",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
}, {
"hash" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151754559",
"triggerID" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"triggerType" : "PUSH"
}, {
"hash" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5925",
"triggerID" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 24a1eb4c4f93bcad751caf10a0b5f52de95f621b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151754559) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5925)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on issue #11230: [FLINK-16300] Rework
SchedulerTestUtils with testing classes to replace mockito usages
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #11230: [FLINK-16300] Rework SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230#issuecomment-594544379
Thanks for the reviewing @tillrohrmann .
Rebased the changes onto latest master and will merge it once travis gives green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11230: [FLINK-16300]
Rework SchedulerTestUtils with testing classes to replace mockito usages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11230: [FLINK-16300] Rework SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230#issuecomment-591836588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150791462",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8c5f1c4014828755123a8680f78dc3fec3a6bf4 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150791462)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11230: [FLINK-16300]
Rework SchedulerTestUtils with testing classes to replace mockito usages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11230: [FLINK-16300] Rework SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230#issuecomment-591836588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150791462",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
}, {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5673",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8c5f1c4014828755123a8680f78dc3fec3a6bf4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150791462) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5673)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11230: [FLINK-16300]
Rework SchedulerTestUtils with testing classes to replace mockito usages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11230: [FLINK-16300] Rework SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230#issuecomment-591836588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150791462",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
}, {
"hash" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5673",
"triggerID" : "d8c5f1c4014828755123a8680f78dc3fec3a6bf4",
"triggerType" : "PUSH"
}, {
"hash" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "24a1eb4c4f93bcad751caf10a0b5f52de95f621b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8c5f1c4014828755123a8680f78dc3fec3a6bf4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150791462) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5673)
* 24a1eb4c4f93bcad751caf10a0b5f52de95f621b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services