You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/20 13:42:22 UTC
[GitHub] [nifi] eduardofontes opened a new pull request, #6226: [NIFI-10252] Processor PutDatabaseRecord generating invalid UPDATE SQL
eduardofontes opened a new pull request, #6226:
URL: https://github.com/apache/nifi/pull/6226
Not always UpdateKey comes in first position
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-10252](https://issues.apache.org/jira/browse/NIFI-10252)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] eduardofontes commented on pull request #6226: [NIFI-10252] Processor PutDatabaseRecord generating invalid UPDATE SQL
Posted by GitBox <gi...@apache.org>.
eduardofontes commented on PR #6226:
URL: https://github.com/apache/nifi/pull/6226#issuecomment-1190546681
@mattyb149
I'll try to do something by next week. There is only one unit test for this processor (testInsertNonRequiredColumnsUnmatchedField), so there is a lot of work to do here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] eduardofontes commented on pull request #6226: [NIFI-10252] Processor PutDatabaseRecord generating invalid UPDATE SQL
Posted by GitBox <gi...@apache.org>.
eduardofontes commented on PR #6226:
URL: https://github.com/apache/nifi/pull/6226#issuecomment-1193225869
@mattyb149
I hadn't seen the groovy test file. It has a lot of unit tests on PutDatabaseRecord.
I added a unit test for this issue, as you asked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #6226: [NIFI-10252] Processor PutDatabaseRecord generating invalid UPDATE SQL
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #6226: [NIFI-10252] Processor PutDatabaseRecord generating invalid UPDATE SQL
URL: https://github.com/apache/nifi/pull/6226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6226: [NIFI-10252] Processor PutDatabaseRecord generating invalid UPDATE SQL
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6226:
URL: https://github.com/apache/nifi/pull/6226#issuecomment-1193947060
Reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6226: [NIFI-10252] Processor PutDatabaseRecord generating invalid UPDATE SQL
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6226:
URL: https://github.com/apache/nifi/pull/6226#issuecomment-1194007976
+1 LGTM, however please put the Jira case number (NIFI-10252) on each commit or at least the first one so it shows up first when squashed. I added an additional unit test for when update keys are specified and the field is not the first one. Also I ran on a live system and everything appears to work correctly. Thanks for the fix! Merging to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6226: [NIFI-10252] Processor PutDatabaseRecord generating invalid UPDATE SQL
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6226:
URL: https://github.com/apache/nifi/pull/6226#issuecomment-1190419743
Can you add a unit test that validates the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org