You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/01/23 19:11:10 UTC

[GitHub] lovelle edited a comment on issue #3411: Fix race condition: broker not scheduling read for active consumer

lovelle edited a comment on issue #3411: Fix race condition: broker not scheduling read for active consumer
URL: https://github.com/apache/pulsar/pull/3411#issuecomment-456928385
 
 
   Hi all! just my 2 cents, isn't `volatile` also be needed in [this field](https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java#L57) since updates and reads could be performed by different threads?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services