Re: [PR] Console modes: --console=plain/rich/verbose/machine [maven]

["gnodet-bot (via GitHub)" <gi...@apache.org>]

gnodet-bot commented on code in PR #13180:
URL: https://github.com/apache/maven/pull/13180#discussion_r4227729644


##########
its/core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/Verifier.java:
##########
@@ -451,17 +451,24 @@ private String doGetLocalRepositoryWithSettings(String settingsXml) {
             if (!Files.isRegularFile(settingsFile)) {
                 throw new IllegalArgumentException("settings xml does not exist: " + settingsXml);
             }
-            return executorTool.localRepository(executorRequest()
-                    .cwd(tempBasedir)
+            ExecutorRequest.Builder builder = executorRequest()
+                    .cwd(basedir)

Review Comment:
   🔶 **Nit — stale comment:** the comment at lines 447-448 now contradicts the code:
   
   > "but we should not use basedir, as it may contain extensions.xml or a project, that Maven will eagerly load"
   
   But the code below now calls `.cwd(basedir)`. If the intent changed (e.g. because the `settings.xml` path must be resolved relative to `basedir`, and the new code mitigates the extension-loading risk differently), the comment should be updated to explain the new rationale. If `basedir` is still problematic here, this change should be reconsidered.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org