You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/09/10 15:14:23 UTC
[GitHub] [incubator-shenyu] rom1c77 opened a new pull request #2052: [ISSUE #2020] Refactor Admin PageHelper to query list.
rom1c77 opened a new pull request #2052:
URL: https://github.com/apache/incubator-shenyu/pull/2052
// Describe your PR here; eg. Fixes #issueNo
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2052: [ISSUE #2020] Refactor Admin PageHelper to query list.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2052:
URL: https://github.com/apache/incubator-shenyu/pull/2052#issuecomment-917019928
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2052](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0fdfaec) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/53704ef8639d3b760c3e8466ae8e7f3a62ee1841?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53704ef) will **decrease** coverage by `0.28%`.
> The diff coverage is `7.89%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2052 +/- ##
============================================
- Coverage 60.83% 60.54% -0.29%
+ Complexity 4034 4028 -6
============================================
Files 606 607 +1
Lines 17833 17871 +38
Branches 1704 1707 +3
============================================
- Hits 10848 10820 -28
- Misses 6110 6170 +60
- Partials 875 881 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/admin/controller/AppAuthController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9BcHBBdXRoQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...enyu/admin/controller/DashboardUserController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9EYXNoYm9hcmRVc2VyQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/MetaDataController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9NZXRhRGF0YUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ache/shenyu/admin/controller/PluginController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5Db250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...henyu/admin/controller/PluginHandleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5IYW5kbGVDb250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/ResourceController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SZXNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RoleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9Sb2xlQ29udHJvbGxlci5qYXZh) | `87.50% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RuleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SdWxlQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/SelectorController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TZWxlY3RvckNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../shenyu/admin/controller/ShenyuDictController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVEaWN0Q29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [53704ef...0fdfaec](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2052: [ISSUE #2020] Refactor Admin PageHelper to query list.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2052:
URL: https://github.com/apache/incubator-shenyu/pull/2052#issuecomment-917019928
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2052](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0fdfaec) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/53704ef8639d3b760c3e8466ae8e7f3a62ee1841?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53704ef) will **decrease** coverage by `0.40%`.
> The diff coverage is `7.89%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2052 +/- ##
============================================
- Coverage 60.83% 60.42% -0.41%
+ Complexity 4034 4023 -11
============================================
Files 606 607 +1
Lines 17833 17871 +38
Branches 1704 1707 +3
============================================
- Hits 10848 10799 -49
- Misses 6110 6191 +81
- Partials 875 881 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/admin/controller/AppAuthController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9BcHBBdXRoQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...enyu/admin/controller/DashboardUserController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9EYXNoYm9hcmRVc2VyQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/MetaDataController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9NZXRhRGF0YUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ache/shenyu/admin/controller/PluginController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5Db250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...henyu/admin/controller/PluginHandleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5IYW5kbGVDb250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/ResourceController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SZXNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RoleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9Sb2xlQ29udHJvbGxlci5qYXZh) | `87.50% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RuleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SdWxlQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/SelectorController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TZWxlY3RvckNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../shenyu/admin/controller/ShenyuDictController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVEaWN0Q29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [53704ef...0fdfaec](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2052: [ISSUE #2020] Refactor Admin PageHelper to query list.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2052:
URL: https://github.com/apache/incubator-shenyu/pull/2052#issuecomment-917019928
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2052](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0fdfaec) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/53704ef8639d3b760c3e8466ae8e7f3a62ee1841?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53704ef) will **decrease** coverage by `0.48%`.
> The diff coverage is `7.89%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2052 +/- ##
============================================
- Coverage 60.83% 60.34% -0.49%
+ Complexity 4034 4022 -12
============================================
Files 606 607 +1
Lines 17833 17871 +38
Branches 1704 1707 +3
============================================
- Hits 10848 10785 -63
- Misses 6110 6204 +94
- Partials 875 882 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/admin/controller/AppAuthController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9BcHBBdXRoQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...enyu/admin/controller/DashboardUserController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9EYXNoYm9hcmRVc2VyQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/MetaDataController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9NZXRhRGF0YUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ache/shenyu/admin/controller/PluginController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5Db250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...henyu/admin/controller/PluginHandleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5IYW5kbGVDb250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/ResourceController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SZXNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RoleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9Sb2xlQ29udHJvbGxlci5qYXZh) | `87.50% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RuleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SdWxlQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/SelectorController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TZWxlY3RvckNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../shenyu/admin/controller/ShenyuDictController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVEaWN0Q29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [53704ef...0fdfaec](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2052: [ISSUE #2020] Refactor Admin PageHelper to query list.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2052:
URL: https://github.com/apache/incubator-shenyu/pull/2052#issuecomment-917019928
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2052](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0fdfaec) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/53704ef8639d3b760c3e8466ae8e7f3a62ee1841?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53704ef) will **decrease** coverage by `0.43%`.
> The diff coverage is `7.89%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2052 +/- ##
============================================
- Coverage 60.83% 60.39% -0.44%
+ Complexity 4034 4022 -12
============================================
Files 606 607 +1
Lines 17833 17871 +38
Branches 1704 1707 +3
============================================
- Hits 10848 10794 -54
- Misses 6110 6198 +88
- Partials 875 879 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/admin/controller/AppAuthController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9BcHBBdXRoQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...enyu/admin/controller/DashboardUserController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9EYXNoYm9hcmRVc2VyQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/MetaDataController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9NZXRhRGF0YUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ache/shenyu/admin/controller/PluginController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5Db250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...henyu/admin/controller/PluginHandleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5IYW5kbGVDb250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/ResourceController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SZXNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RoleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9Sb2xlQ29udHJvbGxlci5qYXZh) | `87.50% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RuleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SdWxlQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/SelectorController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TZWxlY3RvckNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../shenyu/admin/controller/ShenyuDictController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVEaWN0Q29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [53704ef...0fdfaec](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2052: [ISSUE #2020] Refactor Admin PageHelper to query list.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2052:
URL: https://github.com/apache/incubator-shenyu/pull/2052#issuecomment-917019928
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2052](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0fdfaec) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/53704ef8639d3b760c3e8466ae8e7f3a62ee1841?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53704ef) will **decrease** coverage by `0.50%`.
> The diff coverage is `7.89%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2052 +/- ##
============================================
- Coverage 60.83% 60.32% -0.51%
+ Complexity 4034 4021 -13
============================================
Files 606 607 +1
Lines 17833 17871 +38
Branches 1704 1707 +3
============================================
- Hits 10848 10780 -68
- Misses 6110 6210 +100
- Partials 875 881 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/admin/controller/AppAuthController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9BcHBBdXRoQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...enyu/admin/controller/DashboardUserController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9EYXNoYm9hcmRVc2VyQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/MetaDataController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9NZXRhRGF0YUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ache/shenyu/admin/controller/PluginController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5Db250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...henyu/admin/controller/PluginHandleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5IYW5kbGVDb250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/ResourceController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SZXNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RoleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9Sb2xlQ29udHJvbGxlci5qYXZh) | `87.50% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RuleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SdWxlQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/SelectorController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TZWxlY3RvckNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../shenyu/admin/controller/ShenyuDictController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVEaWN0Q29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [53704ef...0fdfaec](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2052: [ISSUE #2020] Refactor Admin PageHelper to query list.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2052:
URL: https://github.com/apache/incubator-shenyu/pull/2052#issuecomment-917019928
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2052](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0fdfaec) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/53704ef8639d3b760c3e8466ae8e7f3a62ee1841?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53704ef) will **decrease** coverage by `0.18%`.
> The diff coverage is `7.89%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2052 +/- ##
============================================
- Coverage 60.83% 60.64% -0.19%
+ Complexity 4034 4032 -2
============================================
Files 606 607 +1
Lines 17833 17871 +38
Branches 1704 1707 +3
============================================
- Hits 10848 10838 -10
- Misses 6110 6154 +44
- Partials 875 879 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/admin/controller/AppAuthController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9BcHBBdXRoQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...enyu/admin/controller/DashboardUserController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9EYXNoYm9hcmRVc2VyQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/MetaDataController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9NZXRhRGF0YUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ache/shenyu/admin/controller/PluginController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5Db250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...henyu/admin/controller/PluginHandleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5IYW5kbGVDb250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/ResourceController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SZXNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RoleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9Sb2xlQ29udHJvbGxlci5qYXZh) | `87.50% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RuleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SdWxlQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/SelectorController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TZWxlY3RvckNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../shenyu/admin/controller/ShenyuDictController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVEaWN0Q29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [53704ef...0fdfaec](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 merged pull request #2052: [ISSUE #2020] Refactor Admin PageHelper to query list.
Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #2052:
URL: https://github.com/apache/incubator-shenyu/pull/2052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #2052: [ISSUE #2020] Refactor Admin PageHelper to query list.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2052:
URL: https://github.com/apache/incubator-shenyu/pull/2052#issuecomment-917019928
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2052](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0fdfaec) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/53704ef8639d3b760c3e8466ae8e7f3a62ee1841?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53704ef) will **decrease** coverage by `0.56%`.
> The diff coverage is `7.89%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2052 +/- ##
============================================
- Coverage 60.83% 60.26% -0.57%
+ Complexity 4034 4020 -14
============================================
Files 606 607 +1
Lines 17833 17868 +35
Branches 1704 1705 +1
============================================
- Hits 10848 10769 -79
- Misses 6110 6220 +110
- Partials 875 879 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/admin/controller/AppAuthController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9BcHBBdXRoQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...enyu/admin/controller/DashboardUserController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9EYXNoYm9hcmRVc2VyQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/MetaDataController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9NZXRhRGF0YUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ache/shenyu/admin/controller/PluginController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5Db250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...henyu/admin/controller/PluginHandleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5IYW5kbGVDb250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/ResourceController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SZXNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RoleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9Sb2xlQ29udHJvbGxlci5qYXZh) | `87.50% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RuleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SdWxlQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/SelectorController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TZWxlY3RvckNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../shenyu/admin/controller/ShenyuDictController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVEaWN0Q29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [17 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2052/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [53704ef...0fdfaec](https://codecov.io/gh/apache/incubator-shenyu/pull/2052?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org