You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/09/30 11:06:18 UTC

[GitHub] [maven] rfscholte commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

rfscholte commented on a change in pull request #558:
URL: https://github.com/apache/maven/pull/558#discussion_r719298137



##########
File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java
##########
@@ -61,39 +61,25 @@
      * @throws DuplicateProjectException
      * @throws CycleDetectedException
      */
-    public DefaultProjectDependencyGraph( Collection<MavenProject> projects )
-        throws CycleDetectedException, DuplicateProjectException
+    public DefaultProjectDependencyGraph( List<MavenProject> projects )

Review comment:
       IMO Maven uses List too often where Collection should have been used. I'm pretty sure this needs to be reverted.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org