[GitHub] [beam] tvalentyn commented on a diff in pull request #22273: Downgrade less informative logs during write to files

[GitBox <gi...@apache.org>]

tvalentyn commented on code in PR #22273:
URL: https://github.com/apache/beam/pull/22273#discussion_r928069583


##########
sdks/python/apache_beam/io/aws/s3io.py:
##########
@@ -157,8 +157,9 @@ def list_prefix(self, path, with_metadata=False):
       else:
         break
 
-    logging.info(
-        "Finished listing %s files in %s seconds.",
+    logging.log(
+        # do not spam logs when list_prefix is likely used to check empty folder
+        logging.INFO if counter > 0 else logging.DEBUG,

Review Comment:
   did you intentionally omit the `"Finished listing %s files in %s seconds.",` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org